Fix deadlock on main thread #294
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix memory leak
|
Can you point me to what is deadlocking and how to reproduce this? Could the deadlock be fixed by not using the main queue for callbacks? If so, it is possible to configure the queue in HubOptions: I am worried that while removing the wait might fix the deadlock you are seeing, it introduces other issues due to race conditions (e.g. someone is starting the connection before the stop has completed). |
Changing queue in HubOptions does not decide the issue. at the and I have: 
Looks when I manually call stop in HubConnection from main thread - all stack will be also on main thread and DispatchGroup will lock main thread if DispatchGroup waiting something. Perhaps when calling stop function in HubConnection should switch to some internal library queue logic, because when using calling DispatchGroup.leave - that do it not from main thread... |
|
Can you enable logging at the diagnostic level and include this log? |
When I start connection - I create new instance from HubConnectionBuilder and stop previous started instance (before create new instance) |
|
Thanks for the logs. Unfortunately, they are hard to understand because it is impossible to tell which entries come from which instance. Would it be possible to somehow tag the instance when logging? Alternatively, could you provide a minimal repro for this so I can try running it on my side? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fast to repeat start / stop actions connection from main thread - could be dead lock on main thread.
General issue decision: https://stackoverflow.com/a/46709947