JSX Documentation #531
JSX Documentation #531
Conversation
|
|
||
| ;; (add-hook 'js-mode-hook 'js2-minor-mode) | ||
|
|
||
| ;; You may also want to hook it in for shell scripts running via node.js: | ||
|
|
||
| ;; (add-to-list 'interpreter-mode-alist '("node" . js2-mode)) | ||
|
|
||
| ;; Support for JSX is available via the derived mode `js2-jsx-mode'. If you |
There was a problem hiding this comment.
Can we really remove this part, keeping in mind that pre-Emacs 27 it is the way to go?
Thinking more about it, maybe that's also the section that the Emacs 27 JSX instructions should go to instead. The "install it as a minor mode" section above gets too bloated with that extra info. Here, though, you can enumerate the cases. Use Emacs 27? Minor mode is the way to go (a note about linting problems would also be more relevant here). Use Emacs 26 or earlier? Do the stuff below.
There was a problem hiding this comment.
Yeah. The organization and wording needed more massaging. I made this change.
README.md
Outdated
|
|
||
| [rjsx-mode](https://github.com/felipeochoa/rjsx-mode/) is an | ||
| alternative option which comes with certain tradeoffs. | ||
| Until [#527](https://github.com/mooz/js2-mode/issues/527) is |
There was a problem hiding this comment.
I don't really mind either way, but... should this go into the wiki instead?
This section is getting a bit long, and it's not like all of our users need to read all this.
Also: if #527 is resolved, we'll probably rewrite the whole recommendation, including the use of the minor mode.
There was a problem hiding this comment.
Less is more. I’ve removed my changes here.
|
Terrific, thank you! |
Since #523 won’t be merged, and as a follow-up to the changes you’ve made so far, I offer these additional documentation changes to compensate for the halfway-finished state of things.