refactor styling of checkboxes #224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FF is hard to style when it comes to checkboxes. With this change we have a label and a span doing the style job and the checkbox just storing the state.
| @@ -18,10 +18,12 @@ block main | |||
|
|
|||
| label | |||
| input(type="checkbox", name="minified", value="1") | |||
| span | |||
| | Download minified source code | |||
There was a problem hiding this comment.
Shouldn't the text be inside the <span>?
There was a problem hiding this comment.
@arian no, the span is just a "holder" for the square showing the "selected"/"not selected" state. So the idea is having the span replacing the checkbox itself that was hard to style and is now display: none;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FF is hard to style when it comes to checkboxes. With this change we
have a label and a span doing the style job and the checkbox just
storing the state.