Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow rotating a subset of collators instead of all of them #770

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

tmpolaczyk
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Nov 28, 2024

WASM runtime size check:

Compared to target branch

dancebox runtime: 1412 KB (no changes) ✅

flashbox runtime: 820 KB (no changes) ✅

dancelight runtime: 2108 KB (no changes) ✅

container chain template simple runtime: 1124 KB (no changes) ✅

container chain template frontier runtime: 1400 KB (no changes) ✅

@tmpolaczyk tmpolaczyk added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Nov 28, 2024
Copy link
Contributor

Coverage Report

(master)

@@                   Coverage Diff                    @@
##           master   tomasz-rotate-subset      +/-   ##
========================================================
- Coverage   64.57%                 64.56%   -0.01%     
+ Files         320                    321       +1     
+ Lines       55407                  55521     +114     
========================================================
+ Hits        35777                  35847      +70     
+ Misses      19630                  19674      +44     
Files Changed Coverage
/node/src/chain_spec/dancebox.rs 94.92% (+0.04%)
/node/src/chain_spec/flashbox.rs 70.66% (-0.16%)
/pallets/collator-assignment/src/assignment.rs 99.33% (+0.04%)
/pallets/collator-assignment/src/lib.rs 96.34% (-0.04%)
/pallets/configuration/src/lib.rs 80.00% (-3.65%)
/primitives/traits/src/lib.rs 65.71% (+0.14%)
/runtime/common/src/migrations.rs 85.51% (-4.81%)
/runtime/dancebox/src/tests/integration_test.rs 99.70% (-0.01%)

Coverage generated Thu Nov 28 18:39:07 UTC 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant