Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork-aware tx-pool polkadot2409 #765

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

chexware
Copy link
Contributor

@chexware chexware commented Nov 27, 2024

PR with changes that enable fork-aware transaction pool

Updates also made in these repos:

@chexware chexware added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B0-silent Changes should not be mentioned in any release notes not-breaking Does not need to be mentioned in breaking changes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit and removed B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes labels Nov 27, 2024
Copy link
Contributor

github-actions bot commented Nov 27, 2024

WASM runtime size check:

Compared to target branch

dancebox runtime: 1424 KB (no changes) ✅

flashbox runtime: 820 KB (no changes) ✅

dancelight runtime: 2072 KB (no changes) ✅

container chain template simple runtime: 1124 KB (no changes) ✅

container chain template frontier runtime: 1400 KB (no changes) ✅

@girazoki
Copy link
Collaborator

Can we add --txpool=fork-aware in all zombienet jobs where we have collators?

Copy link
Contributor

github-actions bot commented Nov 27, 2024

Coverage Report

(master)

@@                              Coverage Diff                              @@
##           master   aleks-polkadot-sdk-stable2409-tx-pool-fix      +/-   ##
=============================================================================
- Coverage   64.57%                                      64.26%   -0.31%     
- Files         320                                         317       -3     
- Lines       55407                                       55374      -33     
=============================================================================
- Hits        35777                                       35585     -192     
+ Misses      19630                                       19789     +159     
Files Changed Coverage
/client/consensus/src/manual_seal.rs 87.39% (-7.20%)
/client/node-common/src/service.rs 47.73% (-0.29%)
/client/service-container-chain/src/service.rs 3.35% (-0.02%)
/container-chains/nodes/frontier/src/rpc/finality.rs 16.33% (-79.59%)
/container-chains/nodes/frontier/src/rpc/mod.rs 55.40% (-13.20%)
/container-chains/nodes/frontier/src/service.rs 56.57% (-23.68%)
/solo-chains/node/tanssi-relay-service/src/dev_service.rs 91.70% (+0.27%)
/solo-chains/runtime/dancelight/src/lib.rs 66.19% (-0.02%)

Coverage generated Wed Nov 27 17:11:53 UTC 2024

Aleksandar Brayanov added 2 commits November 27, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants