Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RawGenesisConfig #758

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Remove RawGenesisConfig #758

merged 2 commits into from
Nov 22, 2024

Conversation

tmpolaczyk
Copy link
Contributor

Not needed after new genesis builder code

Not needed after new genesis builder code
@tmpolaczyk tmpolaczyk added D2-notlive PR doesn't change runtime/client code D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes B0-silent Changes should not be mentioned in any release notes labels Nov 21, 2024
Copy link
Contributor

github-actions bot commented Nov 21, 2024

WASM runtime size check:

Compared to target branch

dancebox runtime: 1412 KB (no changes) ✅

flashbox runtime: 832 KB (no changes) ✅

dancelight runtime: 2008 KB (no changes) ✅

container chain template simple runtime: 1088 KB (no changes) ✅

container chain template frontier runtime: 1388 KB (no changes) ✅

Copy link
Contributor

github-actions bot commented Nov 21, 2024

Coverage Report

(master)

@@                       Coverage Diff                        @@
##           master   tomasz-no-raw-genesis-config      +/-   ##
================================================================
+ Coverage   65.34%                         65.36%   +0.02%     
  Files         310                            310              
- Lines       54174                          54154      -20     
================================================================
  Hits        35395                          35395              
- Misses      18779                          18759      -20     
Files Changed Coverage
/client/service-container-chain/src/chain_spec.rs 100.00% (+80.95%)

Coverage generated Fri Nov 22 09:45:16 UTC 2024

@tmpolaczyk tmpolaczyk merged commit 0504b86 into master Nov 22, 2024
42 checks passed
@tmpolaczyk tmpolaczyk deleted the tomasz-no-raw-genesis-config branch November 22, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime/client code D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants