Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove SKIP_WASM_BUILD=1 environment variable #754

Merged
merged 2 commits into from
Nov 19, 2024
Merged

remove SKIP_WASM_BUILD=1 environment variable #754

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58b1da7
remove SKIP_WASM_BUILD=1 environment variable
ParthDesai Nov 19, 2024
9ae5459
Merge branch 'master' into parth-remove-skip-wasm-build-ci
girazoki Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,9 @@ jobs:
- name: Find toml files with lints key not set
run: ./.github/scripts/check_toml_lints.sh

# Do NOT add SKIP_WASM_BUILD=1 environment variable here as it skips wasm binary build which leads to some compilation bugs escaping clippy
- name: Clippy
run: SKIP_WASM_BUILD=1 cargo clippy --all-targets --locked --workspace --features try-runtime,runtime-benchmarks
run: cargo clippy --all-targets --locked --workspace --features try-runtime,runtime-benchmarks

cargo-toml-feature-propagation:
runs-on: ubuntu-latest
Expand Down
Loading