Prevent std feature injection in runtime-benchmarks feature #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParthDesai
added
not-breaking
WASM runtime size check:Compared to target branchdancebox runtime: 1412 KB (no changes) ✅ flashbox runtime: 832 KB (no changes) ✅ dancelight runtime: 2008 KB (+2008 KB) container chain template simple runtime: 1088 KB (-4224 KB) ✅ container chain template frontier runtime: 1388 KB (-5136 KB) ✅ |
Coverage Report@@ Coverage Diff @@
## master fix-runtime-benchmark-compilation-issue +/- ##
==========================================================================
Coverage 65.34% 65.34% 0.00%
Files 310 310
Lines 54174 54174
==========================================================================
Hits 35395 35395
Misses 18779 18779
|
girazoki
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a bug in compilation of dancelight runtime with
runtime-benchmarksin commit f8b66f3.In that commit we were accidentally injecting
stdfeature intoruntime-benchmarksfeature inexternal-validator-slashespallet. This PR removes it.