Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoke tests for Data Preservers pallet #751

Merged
merged 8 commits into from
Nov 21, 2024
Merged

Conversation

nanocryk
Copy link
Contributor

@nanocryk nanocryk commented Nov 18, 2024

Add smoke tests for this pallet:

  • Check deposit match expected values (0 for forced, or the value defined in the runtime config)
  • If profile is assigned, the witness variant should match the request variant (Free/StreamPayment)

Feel free to suggest other smoke test ideas.

@nanocryk nanocryk added a0-pleasereview Pull request needs code review. B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime/client code not-breaking Does not need to be mentioned in breaking changes labels Nov 18, 2024
Copy link
Contributor

github-actions bot commented Nov 18, 2024

WASM runtime size check:

Compared to target branch

dancebox runtime: 1412 KB (no changes) ✅

flashbox runtime: 832 KB (no changes) ✅

dancelight runtime: 2008 KB (no changes) ✅

container chain template simple runtime: 1088 KB (no changes) ✅

container chain template frontier runtime: 1388 KB (no changes) ✅

Copy link
Contributor

github-actions bot commented Nov 18, 2024

Coverage Report

(master)

@@                      Coverage Diff                       @@
##           master   jeremy-data-preserver-smoke     +/-   ##
==============================================================
  Coverage   65.34%                        65.34%   0.00%     
  Files         310                           310             
  Lines       54174                         54174             
==============================================================
  Hits        35395                         35395             
  Misses      18779                         18779             
Files Changed Coverage

Coverage generated Wed Nov 20 16:40:14 UTC 2024

@girazoki
Copy link
Collaborator

@nanocryk data preservers is a pallet common in dancebox, flashbox and dancelight. Therefore we should add the test in the proper folder (smoke-test-common-all)

@tmpolaczyk
Copy link
Contributor

Test idea: assigned bootnodes have a valid URL (starts with ws or http, not a decode error, etc).

@girazoki
Copy link
Collaborator

Test idea: assigned bootnodes have a valid URL (starts with ws or http, not a decode error, etc).

@nanocryk can we add this small test?

@nanocryk nanocryk merged commit fa4be1c into master Nov 21, 2024
42 checks passed
@nanocryk nanocryk deleted the jeremy-data-preserver-smoke branch November 21, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a0-pleasereview Pull request needs code review. B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime/client code not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants