Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smoke tests for BABE #749

Merged
merged 7 commits into from
Nov 20, 2024
Merged

Add smoke tests for BABE #749

merged 7 commits into from
Nov 20, 2024

Conversation

tmpolaczyk
Copy link
Contributor

@tmpolaczyk tmpolaczyk commented Nov 15, 2024

Add smoke tests for BABE for Dancelight:

  • Authorities have session keys
  • Author according to BABE log is the same as the author that signed the block seal

Copy link
Contributor

github-actions bot commented Nov 15, 2024

WASM runtime size check:

Compared to target branch

dancebox runtime: 1412 KB (no changes) ✅

flashbox runtime: 832 KB (no changes) ✅

dancelight runtime: 2008 KB (no changes) ✅

container chain template simple runtime: 1088 KB (no changes) ✅

container chain template frontier runtime: 1388 KB (no changes) ✅

Copy link
Contributor

github-actions bot commented Nov 15, 2024

Coverage Report

(master)

@@                    Coverage Diff                    @@
##           master   tomasz-smoke-test-babe     +/-   ##
=========================================================
  Coverage   65.34%                   65.34%   0.00%     
  Files         310                      310             
  Lines       54174                    54174             
=========================================================
  Hits        35395                    35395             
  Misses      18779                    18779             
Files Changed Coverage

Coverage generated Wed Nov 20 15:29:59 UTC 2024

@girazoki
Copy link
Collaborator

girazoki commented Nov 18, 2024

Can we add a test where we go back 100 blocks to verify the authors are correct? I think we do something similar with tanssi and aura, see https://github.com/moondance-labs/tanssi/blob/master/test/suites/smoke-test-common-parachain/test-block-author-logs.ts

However I guess you will need to compute a vrf verification, so not sure how easy this is from typescript..

Copy link
Collaborator

@girazoki girazoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description of the PR please!

@tmpolaczyk
Copy link
Contributor Author

However I guess you will need to compute a vrf verification, so not sure how easy this is from typescript..

I was not able to do this because I don't know how to create the message to be verified. It's not a simple concatenation of bytes but something more complex, and with no javascript impl, see https://docs.rs/crate/merlin/latest/source/src/transcript.rs#69

@tmpolaczyk tmpolaczyk added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime/client code not-breaking Does not need to be mentioned in breaking changes labels Nov 19, 2024
@girazoki
Copy link
Collaborator

However I guess you will need to compute a vrf verification, so not sure how easy this is from typescript..

I was not able to do this because I don't know how to create the message to be verified. It's not a simple concatenation of bytes but something more complex, and with no javascript impl, see https://docs.rs/crate/merlin/latest/source/src/transcript.rs#69

yes for now let's leave it out of scope

test/moonwall.config.json Outdated Show resolved Hide resolved
@tmpolaczyk tmpolaczyk merged commit 2760888 into master Nov 20, 2024
42 checks passed
@tmpolaczyk tmpolaczyk deleted the tomasz-smoke-test-babe branch November 20, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime/client code not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants