-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add smoke tests for BABE #749
Conversation
WASM runtime size check:Compared to target branchdancebox runtime: 1412 KB (no changes) ✅ flashbox runtime: 832 KB (no changes) ✅ dancelight runtime: 2008 KB (no changes) ✅ container chain template simple runtime: 1088 KB (no changes) ✅ container chain template frontier runtime: 1388 KB (no changes) ✅ |
Coverage Report@@ Coverage Diff @@
## master tomasz-smoke-test-babe +/- ##
=========================================================
Coverage 65.34% 65.34% 0.00%
Files 310 310
Lines 54174 54174
=========================================================
Hits 35395 35395
Misses 18779 18779
|
Can we add a test where we go back 100 blocks to verify the authors are correct? I think we do something similar with tanssi and aura, see https://github.com/moondance-labs/tanssi/blob/master/test/suites/smoke-test-common-parachain/test-block-author-logs.ts However I guess you will need to compute a vrf verification, so not sure how easy this is from typescript.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description of the PR please!
I was not able to do this because I don't know how to create the message to be verified. It's not a simple concatenation of bytes but something more complex, and with no javascript impl, see https://docs.rs/crate/merlin/latest/source/src/transcript.rs#69 |
yes for now let's leave it out of scope |
Add smoke tests for BABE for Dancelight: