Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates json rpcs #952

Merged
merged 7 commits into from
Jul 30, 2024
Merged

updates json rpcs #952

merged 7 commits into from
Jul 30, 2024

Conversation

dawnkelly09
Copy link
Contributor

Description

  • Adds eth_maxPriorityFeePerGas and eth_newPendingTransactionFilter to the supported Ethereum RPC list.
  • Adds section for known unsupported Ethereum RPC methods
  • Minor punctuation changes per guidelines

Checklist

  • [ x] I have added a label to this PR 🏷️
  • [ x] I have run my changes through Grammarly

@dawnkelly09 dawnkelly09 added the A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.) label Jul 10, 2024
@dawnkelly09 dawnkelly09 requested a review from eshaben July 10, 2024 18:39
dawnkelly09
dawnkelly09 commented Jul 15, 2024
View reviewed changes
Copy link
Contributor Author

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entered suggestions for changing - back to : for list headings

builders/ethereum/json-rpc/eth-rpc.md Outdated Show resolved Hide resolved
builders/ethereum/json-rpc/eth-rpc.md Outdated Show resolved Hide resolved
builders/ethereum/json-rpc/eth-rpc.md Outdated Show resolved Hide resolved
eshaben
eshaben reviewed Jul 24, 2024
View reviewed changes
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to check each of these out! 🙌

Left some comments on minor things 🙂

builders/ethereum/json-rpc/eth-rpc.md Outdated Show resolved Hide resolved
builders/ethereum/json-rpc/eth-rpc.md Outdated Show resolved Hide resolved
builders/ethereum/json-rpc/eth-rpc.md Outdated Show resolved Hide resolved
builders/ethereum/json-rpc/eth-rpc.md Outdated Show resolved Hide resolved
builders/ethereum/json-rpc/eth-rpc.md Outdated Show resolved Hide resolved
builders/ethereum/json-rpc/eth-rpc.md Outdated Show resolved Hide resolved
dawnkelly09
dawnkelly09 commented Jul 24, 2024
View reviewed changes
Copy link
Contributor Author

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added description

builders/ethereum/json-rpc/eth-rpc.md Outdated Show resolved Hide resolved
dawnkelly09
dawnkelly09 commented Jul 24, 2024
View reviewed changes
Copy link
Contributor Author

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes committed per review

eshaben
eshaben reviewed Jul 26, 2024
View reviewed changes
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one tiny thing, but other than that looks good!

builders/ethereum/json-rpc/eth-rpc.md Outdated Show resolved Hide resolved
@dawnkelly09 dawnkelly09 requested a review from eshaben July 29, 2024 16:43
eshaben
eshaben approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✨

@eshaben eshaben merged commit 7edae59 into master Jul 30, 2024
1 check passed
@eshaben eshaben deleted the dawn/update-json-rpcs branch July 30, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshaben eshaben eshaben approved these changes

Assignees
No one assigned
Labels
A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dawnkelly09 @eshaben