Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve xc20 and xc integration docs #704

Merged
merged 12 commits into from
Aug 1, 2023

Conversation

eshaben
Copy link
Contributor

@eshaben eshaben commented Jul 27, 2023

Description

This PR addresses a few items:

  • Create new XC Registration section
  • Split XC integration information out to several pages: Forum templates, Asset Registration, Channel Registration
  • Remove channel registration info from XC-20s overview page
  • Remove interact with XC-20s content from XC-20s overview page and add to new Interact with XC-20s page
  • Add notes on local XC-20 limitations: must match the transfer fn selector described in EIP-20 and limitations on gas
  • Adds some new diagrams to summarize asset registrations flows

Checklist

  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • If pages have been moved around, I have created an additional PR in moonbeam-mkdocs to update redirects

Corresponding PRs

Redirects PR: papermoonio/moonbeam-mkdocs#135

After Translation Requirements

  • Will need to create PR in moonbeam-docs repo to remove images
  • Will need to create PR in moonbeam-mkdocs repo to add redirects for Chinese site

Items to be Updated

👉 Need to apply same redirects for CN site (refer to PR in Corresponding PRs section)
👉 Need to remove the /builders/interoperability/xcm/xc-integration.png index page icon along with all of the images in /builders/interoperability/xcm/xc-integration/*

@eshaben eshaben changed the title rearrange registration and xc20 docs improve xc20 and xc integration docs Jul 27, 2023
@eshaben eshaben requested a review from albertov19 July 27, 2023 15:58
Copy link
Contributor

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor feedback. Thanks for re-arranging the pages, it is much better now <3

Copy link
Contributor

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eshaben eshaben merged commit c2b5b16 into master Aug 1, 2023
1 check passed
@eshaben eshaben deleted the eshaben/erc20s-via-xcm-limitations branch August 1, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants