rsa signing selection, ECDH_RSA and ECDH_ECDSA #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! Thanks for the PR, I'll take a look at it soon! |
|
It looks good overall. Are you interested in adding in the keyx stuff and then TLS could be a lot further along? |
|
Sorry for late answer! Been busy at work this week, but will try to continue on some more tasks next week if ok with you! Do you have any priority list regarding features or? |
Yes, can do that! |
|
No priority list at the moment, just the rest of the TODOs in the BearSSL file (which is mostly getting RSA keys to work as well). Appreciate your work so far! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing some stuff for now, but I'm not sure the ECDH implementation need to differ too much in this section (might be wrong here, feel free to correct).
Also took a look at RSA signing selection, all tests passes but could create more tests anyways