Allow to set a custom error handler in router configuration. #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This pull request provides something like
not_found_handler
but for errors. It also generalizes error response sending inServer
: everything now go through the newhandle_error
which tries to call the error handler, and responds internal server error if the error handler fails. To generalize these calls and the implementation of the handler, I needed to initialize a context instance even before request parsing. This should be taken in account when implementing an error handler, as the request may not be completely initialized if an error happened while parsing it.