Check category tag

[andrewnicols]

Okay, so this adds a category check, which consumes the apis.json in the repo.

It currently doesnt' do anything fancy like checking the allowspread, or allowlevel2.

This is based on top of #110.

I don't know how we should handle disabling of the old moodlecheck rule here because apis.json has only existed since 4.2. Is it possible to disable the moodlecheck rule dependant upon a Moodle version?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.15%. Comparing base (9e7d6f1) to head (491c94f).

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #112      +/-   ##
============================================
+ Coverage     97.07%   97.15%   +0.08%     
- Complexity      633      655      +22     
============================================
  Files            28       29       +1     
  Lines          1809     1864      +55     
============================================
+ Hits           1756     1811      +55     
  Misses           53       53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[andrewnicols]

After discussion with Eloy I've found an approach which satisfies the 4.1 and earlier group. We're using a cached copy of the apis.json from Moodle 4.2 where the file was introduced.

The previous behaviour in moodle-local_moodlecheck was to query the devdocs for the current version so this is more accureate.

[stronk7]

I think this is 99% ready, just have added a couple of comments. Also you've already created #115 so, once the comments are resolved... feel free to merge this.

Ciao :-)

[stronk7]

Yippee!