Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unwanted redirect to IdP from locallogin.php in case alternateloginurl is set, resolves #775 #776

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

krostas1983
Copy link

@krostas1983 krostas1983 commented Nov 27, 2024

As detailed in the corresponding issue, this fix solves various minor problems regarding locallogin.php:

  • Login form should still be displayed if local login is not available due to alternateloginurl being set.
  • Redirect should be to /index.php instead of /login/index.php to prevent certain configurations (again, alternateloginurl) from redirecting to an external login prompt with a valid session.

The feature provided by locallogin.php is very helpful for those cases already where the Moodle WAYF service is not used and all users are expected to come with a valid SSO session.

===========================================

On behalf of the Boost Union Team: 🎉 Thank you for contributing! 🎉

Please note: There must be a GitHub issue for every pull request (PR)

We kindly ask you to create a github issue now if you haven't already done so.

Please make sure to follow these steps to ease the review process for the peer review team:

[x] link your issue in the PR title, using the keyword 'resolves #ISSUE-NUMBER', e.g. 'Feature: Provide the ultimate user experience, resolves #42'
[x] provide any further information that is relevant for peer review and not yet mentioned in the linked issue as a comment in the PR
[x] make sure that the 'Allow edits by maintainers' checkbox is checked when creating the PR. Otherwise, the peer reviewer would not be able to push any review changes to the PR and the communication overhead increases
[x] submit your PR in draft status to run the automated checks and review the results
[ ] in case any checks fail solve the mentioned errors by pushing the corrected code to your PR-branch
[x] if all checks pass (or if you are unable to resolve the failing steps without any help of the review team), mark the PR as 'ready for review'

Thank you again for your contribution, we will start reviewing your PR as soon as we are able to.

In the meantime, please check our wiki page for creating pull requests and our wiki page for reviewing pull requests for further infomation about our contribution and review process.

@krostas1983
Copy link
Author

Commit is compatible with branches MOODLE_401_STABLE to MOODLE_405_STABLE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants