Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#249 - draft: don't force settings duplication, but allow it #250

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danowar2k
Copy link
Collaborator

Added a method that allows child themes to duplicate boost union settings, but doesn't force them to do so, in case child themes want to just reuse boost union's configuration

…ow it

Added a method that allows child themes to duplicate boost union settings, but doesn't force them to do so, in case child themes want to just reuse boost union's configuration
@abias
Copy link
Member

abias commented Mar 23, 2023

Hi @danowar2k ,

many thanks for providing this contribution.
However, as discussed in chat, we will leave this PR pending for a while now as it would introduce some burden onto the theme maintainers and contributors in the long run.

Let's wait if your other PRs for child theme support turn out to be sufficient already.

@danowar2k danowar2k changed the title #249 - don't force settings duplication, but allow it #249 - draft: don't force settings duplication, but allow it Aug 24, 2023
@abias abias marked this pull request as draft February 10, 2024 20:17
@lucaboesch lucaboesch force-pushed the master branch 2 times, most recently from d021aab to 4c0832b Compare March 1, 2024 10:32
@abias abias force-pushed the main branch 3 times, most recently from 5696e9a to b9fa4ca Compare October 21, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement: Do not force child themes to reimplement any theme settings, but allow it
2 participants