Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't warn about issues in dependencies #27

Open
Stuk opened this issue May 22, 2013 · 1 comment
Open

Don't warn about issues in dependencies #27

Stuk opened this issue May 22, 2013 · 1 comment
Assignees
@Stuk
Labels
enhancement

Comments

@Stuk
Copy link
Contributor

Stuk commented May 22, 2013

Currently we output warnings like

(warn) Module file name should be all lower-case node_modules/montage/node_modules/jsdom/node_modules/cssstyle/lib/properties/wordBreak.js

which is not something that can be fixed. We should skip any files in a node_modules directory.
@kriskowal
Copy link
Member

Good call. We should only do it for the app package.

Stuk added a commit to Stuk/mop that referenced this issue Jun 7, 2013
@Stuk
Don't show non-important warnings for other packages
ab2b593 
See montagejsgh-27
This was referenced Jun 7, 2013
Closed
Closed
Stuk added a commit to Stuk/mop that referenced this issue Jun 13, 2013
@Stuk
Don't show non-important warnings for other packages
98725f8 
See montagejsgh-27
@Stuk Stuk self-assigned this May 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stuk Stuk

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stuk @kriskowal