serve the way w3c sez to do it #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if ($cors = OP) { | ||
| add_header 'Access-Control-Allow-Origin' $http_origin; | ||
| # these are only needed on OPTIONS | ||
| add_header 'Access-Control-Allow-Credentials' 'true'; # techically only needed if doing credentials |
There was a problem hiding this comment.
The comment on line 35 makes it seem like Access-Control-Allow-Credentials are only required on OPTIONS requests, but it is needed on both the preflight and the actual request (if it is used).
|
feedback taken. code adjusted. --timball |
|
pull code ? |
|
Sorry I'm traveling these past two weeks. I'll try to get to this by the On Mon, Jun 22, 2015 at 10:17 PM timball [email protected] wrote:
|
|
So what is the current status of permissive CORS setup for nginx, @monsur? I skimmed through all suggestion for past 6 years and this is what I found:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of the nginx configs did not follow the recommendations of the w3c and as a result some clients would balk at the headers being served. This PR fixes issue #102.
--timball