Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Direct3D backend #121

Open
wants to merge 4 commits into
base: skiasharp
Choose a base branch
from
Open

Expose Direct3D backend #121

wants to merge 4 commits into from

Conversation

Kation
Copy link

@Kation Kation commented Apr 8, 2024

Description of Change

Expose Direct3D backend

SkiaSharp Issue

Related to mono/SkiaSharp#2817

API Changes

Added:

  • gr_direct_context_t* gr_direct_context_make_direct3d(const gr_d3d_backendcontext_t d3dBackendContext);
  • gr_direct_context_t* gr_direct_context_make_direct3d_with_options(const gr_d3d_backendcontext_t d3dBackendContext, const gr_context_options_t* options);
  • gr_backendtexture_t* gr_backendtexture_new_direct3d(int width, int height, const gr_d3d_textureinfo_t* d3dInfo);
  • gr_backendrendertarget_t* gr_backendrendertarget_new_direct3d(int width, int height, const gr_d3d_textureinfo_t* d3dInfo);

Behavioral Changes

None.

Required SkiaSharp PR

None.

PR Checklist

  • Rebased on top of skiasharp at time of PR
  • Changes adhere to coding standard
  • Updated documentation

@Kation
Copy link
Author

Kation commented Apr 8, 2024

@dotnet-policy-service agree

Copy link

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR - I see CI is green. I have a whole bunch of comments that is more just API shape and general interop.

include/c/sk_types.h Outdated Show resolved Hide resolved
include/c/sk_types.h Show resolved Hide resolved
include/c/sk_types.h Outdated Show resolved Hide resolved
include/c/sk_types.h Show resolved Hide resolved
include/c/sk_types.h Outdated Show resolved Hide resolved
include/c/sk_types.h Show resolved Hide resolved
include/c/sk_types.h Show resolved Hide resolved
include/c/sk_types.h Outdated Show resolved Hide resolved
src/c/sk_types_priv.h Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants