Couldn't remove modules without translation units #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I do not know I'm first to encounter this, however, loop that removes module without translation units, could not have worked. In C# Enumerator prohibs editing the collection so you cannot remove modules from `options.Module` while iterating `options.Mobule`. Chose `RemoveAll` for its simplicity. Not necessary optimal solution although it might be.
|
@dotnet-policy-service agree |
|
Thank you. Fastest merge request I have ever requested. 👏 |
Thanks for the contribution too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not know I'm first to encounter this, however, loop that removes modules without translation units, could not have worked.
In C# Enumerator prohibits editing the collection so you cannot remove modules from
options.Modulewhile iteratingoptions.Module.Chose
RemoveAllfor its simplicity. Not necessary optimal solution although it might be.