-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ARM64 support on LLVM builds #1824
Conversation
@dotnet-policy-service agree |
Tests are failing as the pulled LLVM will need to be rebuilt with |
Spawned some LLVM builds: https://github.com/mono/CppSharp/actions/runs/7760243198 |
Will I need to do anything special to point to these artifacts? |
Nope, after it finishes building, I'll need to replace the current builds on the releases page with these new ones. After that, the builds for this PR should hopefully progress. |
Great. Thanks again for your assistance on this! |
Can you update the PR with the new ARM64 CI builds: https://github.com/mono/CppSharp/blob/main/.github/workflows/main.yml#L12 |
Done! |
My bad, those are failing of course, I thought you already added the new ARM64 parser bindings, but this PR is specifically for the LLVM support. 🤦 So feel free to remove that last commit and we can this one merged. |
OK looks like the rest of the errors are predicated on updated bindings. Working on it now. EDIT: let me see if I can gen the bindings quick. I've got Mac headers, I'll collect Linux momentarily. |
Nah you were right, this patch is too big for this PR. Gonna make a dependent branch and open another. |
As suggested by @tritao in #1708 this PR adds support for building LLVM for ARM64 hosts, and adds ARM64 decompilation libs to the linkage.