Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ClassTemplatePartialSpecialization::Parameters #1809

Conversation

deadlocklogic
Copy link
Contributor

@deadlocklogic deadlocklogic commented Dec 16, 2023

Closes #1801

  1. I only added Parameters field.
  2. Extracted the headers.zip to the build directory
  3. Rebuild the whole solution

Still no new bindings are being generated.

Edit 1:
I found out that I should run, not only build the project.
Edit 2:
Even with running the CppSharp.Parser.Gen isn't generating bindings.

@deadlocklogic deadlocklogic marked this pull request as draft December 16, 2023 16:03
@deadlocklogic
Copy link
Contributor Author

@tritao Why CppSharp.Parser.Gen generated bindings are in src\CppParser\Bindings\CSharp.Generators.GeneratorKind not in src\CppParser\Bindings\CSharp?
Maybe this is a bug introduced after refactoring GeneratorKind from enum to a class right? in #1794

options.OutputDir = Path.Combine(GetSourceDirectory("src"), "CppParser",
"Bindings", Kind.ToString());

I will fix it now.😔

@deadlocklogic
Copy link
Contributor Author

deadlocklogic commented Dec 16, 2023

Indeed it was a bug, I fixed it with this commit, just implemented explicitly GeneratorKind.ToString(). Because enum have an implicit ToString() which returns the name.

@deadlocklogic
Copy link
Contributor Author

deadlocklogic commented Dec 16, 2023

Ok, now I can continue this PR, but unfortunately we have to revert #1802 so I can re-test it carefully. Because I was the whole time testing against same non regenerated bindings and now tests are failing. I believe the fix should be simple but lets safely revert and rework the PR.
This is so embarrassing, such a simple bug had devastating effects. #1810 will revert the changes for the time being.
At least, we can see the positive side of catching this nasty bug early before it is way too late.

@tritao
Copy link
Collaborator

tritao commented Dec 16, 2023

We once before had the CI automatically commit re-generated parser bindings, but that caused some issues. Maybe it's time to get that working again, and instead of automatically committing, maybe just erroring the build when the committer forgets to re-generate the parser bindings.

@deadlocklogic
Copy link
Contributor Author

Indeed this step is really worth keeping an eye on whenever modifying the CLI/C# backend. Maybe we could add a notice on new issues and add a new PR template which could make new contributors aware of this.

@deadlocklogic
Copy link
Contributor Author

@tritao This PR is ready once you decide on: #1810

Notice:

I had to push the newly generated bindings which introduced parameterless constructors, because these changes weren't introduced by me and couldn't decide on them.
As you can see, tests fail because the C# 10.0 requirement.

@tritao
Copy link
Collaborator

tritao commented Dec 17, 2023

Can you open another PR with just the re-generated bindings now? And in that PR I think we can also just upgrade the C# version to 10.0: https://github.com/mono/CppSharp/blob/main/Directory.Build.props#L31

@deadlocklogic
Copy link
Contributor Author

Ok will do now.

deadlocklogic and others added 4 commits December 17, 2023 14:33
* regenerated bindings

* regenerated bindings after rebase

* Directory.Build.props: support C# 10.0
@deadlocklogic deadlocklogic marked this pull request as ready for review December 17, 2023 12:55
@deadlocklogic
Copy link
Contributor Author

@tritao Ready for review, maybe needs tests, but I don't know exactly the preferred code style.

@deadlocklogic deadlocklogic marked this pull request as draft December 17, 2023 14:04
@deadlocklogic deadlocklogic marked this pull request as ready for review December 17, 2023 14:40
@deadlocklogic
Copy link
Contributor Author

@tritao Added a test anyway. Objectively speaking the tests need refactoring.
Asserting Declaration count is something, but assertions based on the line number of the parsed AST entity is something else.😂
We should move such line number based tests to a separate file.

@tritao
Copy link
Collaborator

tritao commented Dec 17, 2023

Cool, nice work!

@tritao tritao merged commit 9071cd2 into mono:main Dec 17, 2023
5 checks passed
JordanL8 added a commit to MoonCollider/CppSharp that referenced this pull request Feb 1, 2024
commit b5ab95e
Author: Joao Matos <[email protected]>
Date:   Thu Feb 1 11:39:24 2024 +0000

    Update iOS64 ABI name to the more accurate AppleARM64.

commit d1307a5
Author: Joao Matos <[email protected]>
Date:   Thu Feb 1 11:21:52 2024 +0000

    Add support for AArch64 C++ ABI.

commit 9071cd2
Author: deadlocklogic <[email protected]>
Date:   Sun Dec 17 17:03:24 2023 +0200

    Implement ClassTemplatePartialSpecialization::Parameters (mono#1809)

    * Implement ClassTemplatePartialSpecialization::Parameters

    * Template.cs: Implement ClassTemplatePartialSpecialization.Parameters

    * GeneratorKind: fix bug introduced while migrating from enum to class

    * Implement native ClassTemplatePartialSpecialization.Parameters + ASTConverter

    * regenerated bindings (mono#1813)

    * regenerated bindings

    * regenerated bindings after rebase

    * Directory.Build.props: support C# 10.0

    * Implement native ClassTemplatePartialSpecialization.Parameters + ASTConverter

    * Regenerated bindings

    * TestAST.cs: add TestASTClassTemplatePartialSpecialization

commit 2ecd952
Author: deadlocklogic <[email protected]>
Date:   Sun Dec 17 13:08:34 2023 +0200

    regenerated bindings (mono#1813)

    * regenerated bindings

    * regenerated bindings after rebase

    * Directory.Build.props: support C# 10.0

commit 24d1a84
Author: deadlocklogic <[email protected]>
Date:   Sun Dec 17 11:44:00 2023 +0200

    Stdlib.CSharp.cs: remove buggy typemap (mono#1812)

commit 1327971
Author: deadlocklogic <[email protected]>
Date:   Sat Dec 16 21:36:04 2023 +0200

    GeneratorKind: patch bug caused by missing ToString (mono#1811)

commit 519e97f
Author: Joao Matos <[email protected]>
Date:   Tue Dec 12 15:30:14 2023 +0000

    Remove 32-bit builds and non-debug symbols release builds from LLVM Windows CI.

commit 1211272
Author: deadlocklogic <[email protected]>
Date:   Tue Dec 12 17:25:12 2023 +0200

    Build llvm `Debug`/`Release` for `Windows`. (mono#1800)

    * Update llvm-win.yml

    * Update llvm-win.yml

    * Update llvm-win.yml

commit 12c267d
Author: zylalx1 <[email protected]>
Date:   Fri Dec 8 03:58:10 2023 +0800

    Fixed a bug causing the header file to be included twice when Options.GenerateName is not null (mono#1803)

commit e068f2a
Author: deadlocklogic <[email protected]>
Date:   Thu Dec 7 16:35:02 2023 +0200

    Typemap cleanup (mono#1802)

    * TypeMap: prepare refactoring into a modular design

    * TypeMap: refactor C++ backend into common methods

    * TypeMap: refactor CLI backend into common methods

    * CLI.Gen.cs: fix omitted typemap from previous commit

    * Common.Gen.cs: fixed silly modification while testing

    * GeneratorKind: add FindGeneratorKindByID method

    * TypeMapDatabase: heavy refactor: group typemaps by GeneratorKind

    * TypeMap: refactor CSharp backend into common methods + migration

    * TypeMap: cleanup patches from previous commits

    * TypeMapDatabase: fix passing GeneratorKind to FindTypeMap calls

    * Stdlib.CSharp.cs: move std::map typemap from Stdlib.CLI.cs

    * TypeMapDatabase: improve parameter name

commit 8c2da6d
Author: deadlocklogic <[email protected]>
Date:   Mon Nov 13 22:00:41 2023 +0200

    Major refactor: TypePrinter: improve modular design + cleanup (mono#1796)

commit 0edd48c
Author: deadlocklogic <[email protected]>
Date:   Mon Nov 13 20:15:24 2023 +0200

    Major refactoring: refactor GeneratorKind enum into a class (mono#1794)

    * Major refactoring: refactor GeneratorKind enum into a class

    * Minor fix: add readonly

    * Add Type property for GenerationKind + cleanup

    * GeneratorKind: add Name property + refactor hardcoded names

    * GeneratorKind: add CLIOptions property + refactor hardcoded options

    * CppSharp.CLI: minor fix: use generator.ToLower()

    * GeneratorKind: fix warning

commit 40f3a09
Author: deadlocklogic <[email protected]>
Date:   Sat Nov 11 16:51:18 2023 +0200

    Minor improvements (mono#1793)

    * CppSharp.Generators.Options: added pre/post TranslationUnitPass callback

    * CppSharp.Generators.Passes.Pass: added TranslationUnitPassGeneratorDependent

commit b14038a
Author: Stefan <[email protected]>
Date:   Mon Oct 23 14:23:51 2023 +0200

    Value types may generate `Dispose` (mono#1787)

commit 3b2a15d
Author: João Matos <[email protected]>
Date:   Sat Oct 21 19:33:13 2023 +0100

    Update README.md

commit a5afda8
Author: Stefan <[email protected]>
Date:   Fri Oct 20 21:00:04 2023 +0200

    Fix parameterless constructors not being generated for structs (mono#1783)

    * Fix parameterless constructors not being generated for structs

    * Fix implicit non-trivial default ctor

    * Adjust `Ignore` linked issue

commit b16e809
Author: Stefan <[email protected]>
Date:   Fri Oct 20 18:54:58 2023 +0200

    Introduce `GenerateFreeStandingFunctionsClassName` option (mono#1782)

    * Introduce `GenerateFreeStandingFunctionsClassName` option

    * Support CLI and fixes

commit 03874e7
Author: Stefan <[email protected]>
Date:   Thu Oct 19 17:24:55 2023 +0200

    Fix Value Type String Member Invalid Codegen (mono#1778)

    * Fix code generation

    * Generate exception on broken struct set op

    * Remove redundant usings

commit adffc99
Author: Salvage <[email protected]>
Date:   Thu Oct 19 14:51:06 2023 +0200

    Fix erroneous newline

commit b4f261e
Author: Salvage <[email protected]>
Date:   Thu Oct 19 14:26:00 2023 +0200

    Simplify `IsTemplateParameterType`

commit 28000a1
Author: Salvage <[email protected]>
Date:   Thu Oct 19 01:19:07 2023 +0200

    Fix mono#1251 three parameter equality operator

    - Operators in generic classes do not attempt to generate as extension methods anymore
    - Empty `...Extensions` classes are no longer generated
    - `string` as a template argument is correctly cast
    - `MarshalCharAsManagedChar` option also generates correct casts
    - Suppress warning regarding returning struct field by ref
    - Eliminate some tabs that snuck into the test C++ header

commit d7faf5f
Author: Joao Matos <[email protected]>
Date:   Wed Oct 18 17:39:49 2023 +0100

    Fix SDL_PollEvent generation in the SDL example.

    Fixes mono#978.

    Thanks to @Saalvage.

commit 7f567b6
Author: Salvage <[email protected]>
Date:   Wed Oct 18 18:26:03 2023 +0200

    Fix non-void returning functions with value-type out parameters

    Also fixes indentation

commit 0c60384
Author: Salvage <[email protected]>
Date:   Wed Oct 18 16:49:41 2023 +0200

    Additional bump

commit 0534e33
Author: Salvage <[email protected]>
Date:   Wed Oct 18 16:35:10 2023 +0200

    Bump GH actions versions to solve warnings

commit a6ef9d9
Author: Salvage <[email protected]>
Date:   Wed Oct 18 16:19:42 2023 +0200

    Fix source dir

commit 7e6c492
Author: Salvage <[email protected]>
Date:   Wed Oct 18 16:08:51 2023 +0200

    Test fix broken packages

commit 2a351b7
Author: Joao Matos <[email protected]>
Date:   Wed Oct 18 16:03:36 2023 +0100

    Update our version to 1.1.

commit 20950c5
Author: Salvage <[email protected]>
Date:   Wed Oct 18 04:58:38 2023 +0200

    More stringent test; Fix indentation (of the code itself, not in the generator)

commit ebe6b8a
Author: Salvage <[email protected]>
Date:   Wed Oct 18 04:47:13 2023 +0200

    Fix value type out parameters
JordanL8 added a commit to MoonCollider/CppSharp that referenced this pull request Feb 5, 2024
commit 1d1b21f
Author: Conrad Kreyling <[email protected]>
Date:   Fri Feb 2 15:12:42 2024 -0500

    Instruct generator to build ARM64 bindings

commit 491248b
Author: Conrad Kreyling <[email protected]>
Date:   Fri Feb 2 15:09:44 2024 -0500

    Fix missing AArch64 entry in CLI CppAbi

commit bbb0693
Author: Conrad Kreyling <[email protected]>
Date:   Fri Feb 2 13:35:11 2024 -0500

    Enable ARM64 support on LLVM builds

commit b5ab95e
Author: Joao Matos <[email protected]>
Date:   Thu Feb 1 11:39:24 2024 +0000

    Update iOS64 ABI name to the more accurate AppleARM64.

commit d1307a5
Author: Joao Matos <[email protected]>
Date:   Thu Feb 1 11:21:52 2024 +0000

    Add support for AArch64 C++ ABI.

commit 9071cd2
Author: deadlocklogic <[email protected]>
Date:   Sun Dec 17 17:03:24 2023 +0200

    Implement ClassTemplatePartialSpecialization::Parameters (mono#1809)

    * Implement ClassTemplatePartialSpecialization::Parameters

    * Template.cs: Implement ClassTemplatePartialSpecialization.Parameters

    * GeneratorKind: fix bug introduced while migrating from enum to class

    * Implement native ClassTemplatePartialSpecialization.Parameters + ASTConverter

    * regenerated bindings (mono#1813)

    * regenerated bindings

    * regenerated bindings after rebase

    * Directory.Build.props: support C# 10.0

    * Implement native ClassTemplatePartialSpecialization.Parameters + ASTConverter

    * Regenerated bindings

    * TestAST.cs: add TestASTClassTemplatePartialSpecialization

commit 2ecd952
Author: deadlocklogic <[email protected]>
Date:   Sun Dec 17 13:08:34 2023 +0200

    regenerated bindings (mono#1813)

    * regenerated bindings

    * regenerated bindings after rebase

    * Directory.Build.props: support C# 10.0

commit 24d1a84
Author: deadlocklogic <[email protected]>
Date:   Sun Dec 17 11:44:00 2023 +0200

    Stdlib.CSharp.cs: remove buggy typemap (mono#1812)

commit 1327971
Author: deadlocklogic <[email protected]>
Date:   Sat Dec 16 21:36:04 2023 +0200

    GeneratorKind: patch bug caused by missing ToString (mono#1811)

commit 519e97f
Author: Joao Matos <[email protected]>
Date:   Tue Dec 12 15:30:14 2023 +0000

    Remove 32-bit builds and non-debug symbols release builds from LLVM Windows CI.

commit 1211272
Author: deadlocklogic <[email protected]>
Date:   Tue Dec 12 17:25:12 2023 +0200

    Build llvm `Debug`/`Release` for `Windows`. (mono#1800)

    * Update llvm-win.yml

    * Update llvm-win.yml

    * Update llvm-win.yml

commit 12c267d
Author: zylalx1 <[email protected]>
Date:   Fri Dec 8 03:58:10 2023 +0800

    Fixed a bug causing the header file to be included twice when Options.GenerateName is not null (mono#1803)

commit e068f2a
Author: deadlocklogic <[email protected]>
Date:   Thu Dec 7 16:35:02 2023 +0200

    Typemap cleanup (mono#1802)

    * TypeMap: prepare refactoring into a modular design

    * TypeMap: refactor C++ backend into common methods

    * TypeMap: refactor CLI backend into common methods

    * CLI.Gen.cs: fix omitted typemap from previous commit

    * Common.Gen.cs: fixed silly modification while testing

    * GeneratorKind: add FindGeneratorKindByID method

    * TypeMapDatabase: heavy refactor: group typemaps by GeneratorKind

    * TypeMap: refactor CSharp backend into common methods + migration

    * TypeMap: cleanup patches from previous commits

    * TypeMapDatabase: fix passing GeneratorKind to FindTypeMap calls

    * Stdlib.CSharp.cs: move std::map typemap from Stdlib.CLI.cs

    * TypeMapDatabase: improve parameter name

commit 8c2da6d
Author: deadlocklogic <[email protected]>
Date:   Mon Nov 13 22:00:41 2023 +0200

    Major refactor: TypePrinter: improve modular design + cleanup (mono#1796)

commit 0edd48c
Author: deadlocklogic <[email protected]>
Date:   Mon Nov 13 20:15:24 2023 +0200

    Major refactoring: refactor GeneratorKind enum into a class (mono#1794)

    * Major refactoring: refactor GeneratorKind enum into a class

    * Minor fix: add readonly

    * Add Type property for GenerationKind + cleanup

    * GeneratorKind: add Name property + refactor hardcoded names

    * GeneratorKind: add CLIOptions property + refactor hardcoded options

    * CppSharp.CLI: minor fix: use generator.ToLower()

    * GeneratorKind: fix warning

commit 40f3a09
Author: deadlocklogic <[email protected]>
Date:   Sat Nov 11 16:51:18 2023 +0200

    Minor improvements (mono#1793)

    * CppSharp.Generators.Options: added pre/post TranslationUnitPass callback

    * CppSharp.Generators.Passes.Pass: added TranslationUnitPassGeneratorDependent

commit b14038a
Author: Stefan <[email protected]>
Date:   Mon Oct 23 14:23:51 2023 +0200

    Value types may generate `Dispose` (mono#1787)

commit 3b2a15d
Author: João Matos <[email protected]>
Date:   Sat Oct 21 19:33:13 2023 +0100

    Update README.md

commit a5afda8
Author: Stefan <[email protected]>
Date:   Fri Oct 20 21:00:04 2023 +0200

    Fix parameterless constructors not being generated for structs (mono#1783)

    * Fix parameterless constructors not being generated for structs

    * Fix implicit non-trivial default ctor

    * Adjust `Ignore` linked issue

commit b16e809
Author: Stefan <[email protected]>
Date:   Fri Oct 20 18:54:58 2023 +0200

    Introduce `GenerateFreeStandingFunctionsClassName` option (mono#1782)

    * Introduce `GenerateFreeStandingFunctionsClassName` option

    * Support CLI and fixes

commit 03874e7
Author: Stefan <[email protected]>
Date:   Thu Oct 19 17:24:55 2023 +0200

    Fix Value Type String Member Invalid Codegen (mono#1778)

    * Fix code generation

    * Generate exception on broken struct set op

    * Remove redundant usings

commit adffc99
Author: Salvage <[email protected]>
Date:   Thu Oct 19 14:51:06 2023 +0200

    Fix erroneous newline

commit b4f261e
Author: Salvage <[email protected]>
Date:   Thu Oct 19 14:26:00 2023 +0200

    Simplify `IsTemplateParameterType`

commit 28000a1
Author: Salvage <[email protected]>
Date:   Thu Oct 19 01:19:07 2023 +0200

    Fix mono#1251 three parameter equality operator

    - Operators in generic classes do not attempt to generate as extension methods anymore
    - Empty `...Extensions` classes are no longer generated
    - `string` as a template argument is correctly cast
    - `MarshalCharAsManagedChar` option also generates correct casts
    - Suppress warning regarding returning struct field by ref
    - Eliminate some tabs that snuck into the test C++ header

commit d7faf5f
Author: Joao Matos <[email protected]>
Date:   Wed Oct 18 17:39:49 2023 +0100

    Fix SDL_PollEvent generation in the SDL example.

    Fixes mono#978.

    Thanks to @Saalvage.

commit 7f567b6
Author: Salvage <[email protected]>
Date:   Wed Oct 18 18:26:03 2023 +0200

    Fix non-void returning functions with value-type out parameters

    Also fixes indentation

commit 0c60384
Author: Salvage <[email protected]>
Date:   Wed Oct 18 16:49:41 2023 +0200

    Additional bump

commit 0534e33
Author: Salvage <[email protected]>
Date:   Wed Oct 18 16:35:10 2023 +0200

    Bump GH actions versions to solve warnings

commit a6ef9d9
Author: Salvage <[email protected]>
Date:   Wed Oct 18 16:19:42 2023 +0200

    Fix source dir

commit 7e6c492
Author: Salvage <[email protected]>
Date:   Wed Oct 18 16:08:51 2023 +0200

    Test fix broken packages

commit 2a351b7
Author: Joao Matos <[email protected]>
Date:   Wed Oct 18 16:03:36 2023 +0100

    Update our version to 1.1.

commit 20950c5
Author: Salvage <[email protected]>
Date:   Wed Oct 18 04:58:38 2023 +0200

    More stringent test; Fix indentation (of the code itself, not in the generator)

commit ebe6b8a
Author: Salvage <[email protected]>
Date:   Wed Oct 18 04:47:13 2023 +0200

    Fix value type out parameters
JordanL8 added a commit to MoonCollider/CppSharp that referenced this pull request Feb 7, 2024
commit 8bd3f45
Author: João Matos <[email protected]>
Date:   Tue Feb 6 18:30:12 2024 +0000

    Update llvm.yml to install AArch64 cross compilers

commit a81abd5
Author: Conrad Kreyling <[email protected]>
Date:   Tue Feb 6 11:29:07 2024 -0500

    LLVM crosscompile x64 for ARM64 (mono#1826)

    * LLVM crosscompile x64 for ARM64

    * Fix MacOS host platform test

    * Ensure options is persistent in cross compile paths

commit 1d1b21f
Author: Conrad Kreyling <[email protected]>
Date:   Fri Feb 2 15:12:42 2024 -0500

    Instruct generator to build ARM64 bindings

commit 491248b
Author: Conrad Kreyling <[email protected]>
Date:   Fri Feb 2 15:09:44 2024 -0500

    Fix missing AArch64 entry in CLI CppAbi

commit bbb0693
Author: Conrad Kreyling <[email protected]>
Date:   Fri Feb 2 13:35:11 2024 -0500

    Enable ARM64 support on LLVM builds

commit b5ab95e
Author: Joao Matos <[email protected]>
Date:   Thu Feb 1 11:39:24 2024 +0000

    Update iOS64 ABI name to the more accurate AppleARM64.

commit d1307a5
Author: Joao Matos <[email protected]>
Date:   Thu Feb 1 11:21:52 2024 +0000

    Add support for AArch64 C++ ABI.

commit 9071cd2
Author: deadlocklogic <[email protected]>
Date:   Sun Dec 17 17:03:24 2023 +0200

    Implement ClassTemplatePartialSpecialization::Parameters (mono#1809)

    * Implement ClassTemplatePartialSpecialization::Parameters

    * Template.cs: Implement ClassTemplatePartialSpecialization.Parameters

    * GeneratorKind: fix bug introduced while migrating from enum to class

    * Implement native ClassTemplatePartialSpecialization.Parameters + ASTConverter

    * regenerated bindings (mono#1813)

    * regenerated bindings

    * regenerated bindings after rebase

    * Directory.Build.props: support C# 10.0

    * Implement native ClassTemplatePartialSpecialization.Parameters + ASTConverter

    * Regenerated bindings

    * TestAST.cs: add TestASTClassTemplatePartialSpecialization

commit 2ecd952
Author: deadlocklogic <[email protected]>
Date:   Sun Dec 17 13:08:34 2023 +0200

    regenerated bindings (mono#1813)

    * regenerated bindings

    * regenerated bindings after rebase

    * Directory.Build.props: support C# 10.0

commit 24d1a84
Author: deadlocklogic <[email protected]>
Date:   Sun Dec 17 11:44:00 2023 +0200

    Stdlib.CSharp.cs: remove buggy typemap (mono#1812)

commit 1327971
Author: deadlocklogic <[email protected]>
Date:   Sat Dec 16 21:36:04 2023 +0200

    GeneratorKind: patch bug caused by missing ToString (mono#1811)

commit 519e97f
Author: Joao Matos <[email protected]>
Date:   Tue Dec 12 15:30:14 2023 +0000

    Remove 32-bit builds and non-debug symbols release builds from LLVM Windows CI.

commit 1211272
Author: deadlocklogic <[email protected]>
Date:   Tue Dec 12 17:25:12 2023 +0200

    Build llvm `Debug`/`Release` for `Windows`. (mono#1800)

    * Update llvm-win.yml

    * Update llvm-win.yml

    * Update llvm-win.yml

commit 12c267d
Author: zylalx1 <[email protected]>
Date:   Fri Dec 8 03:58:10 2023 +0800

    Fixed a bug causing the header file to be included twice when Options.GenerateName is not null (mono#1803)

commit e068f2a
Author: deadlocklogic <[email protected]>
Date:   Thu Dec 7 16:35:02 2023 +0200

    Typemap cleanup (mono#1802)

    * TypeMap: prepare refactoring into a modular design

    * TypeMap: refactor C++ backend into common methods

    * TypeMap: refactor CLI backend into common methods

    * CLI.Gen.cs: fix omitted typemap from previous commit

    * Common.Gen.cs: fixed silly modification while testing

    * GeneratorKind: add FindGeneratorKindByID method

    * TypeMapDatabase: heavy refactor: group typemaps by GeneratorKind

    * TypeMap: refactor CSharp backend into common methods + migration

    * TypeMap: cleanup patches from previous commits

    * TypeMapDatabase: fix passing GeneratorKind to FindTypeMap calls

    * Stdlib.CSharp.cs: move std::map typemap from Stdlib.CLI.cs

    * TypeMapDatabase: improve parameter name

commit 8c2da6d
Author: deadlocklogic <[email protected]>
Date:   Mon Nov 13 22:00:41 2023 +0200

    Major refactor: TypePrinter: improve modular design + cleanup (mono#1796)

commit 0edd48c
Author: deadlocklogic <[email protected]>
Date:   Mon Nov 13 20:15:24 2023 +0200

    Major refactoring: refactor GeneratorKind enum into a class (mono#1794)

    * Major refactoring: refactor GeneratorKind enum into a class

    * Minor fix: add readonly

    * Add Type property for GenerationKind + cleanup

    * GeneratorKind: add Name property + refactor hardcoded names

    * GeneratorKind: add CLIOptions property + refactor hardcoded options

    * CppSharp.CLI: minor fix: use generator.ToLower()

    * GeneratorKind: fix warning

commit 40f3a09
Author: deadlocklogic <[email protected]>
Date:   Sat Nov 11 16:51:18 2023 +0200

    Minor improvements (mono#1793)

    * CppSharp.Generators.Options: added pre/post TranslationUnitPass callback

    * CppSharp.Generators.Passes.Pass: added TranslationUnitPassGeneratorDependent

commit b14038a
Author: Stefan <[email protected]>
Date:   Mon Oct 23 14:23:51 2023 +0200

    Value types may generate `Dispose` (mono#1787)

commit 3b2a15d
Author: João Matos <[email protected]>
Date:   Sat Oct 21 19:33:13 2023 +0100

    Update README.md

commit a5afda8
Author: Stefan <[email protected]>
Date:   Fri Oct 20 21:00:04 2023 +0200

    Fix parameterless constructors not being generated for structs (mono#1783)

    * Fix parameterless constructors not being generated for structs

    * Fix implicit non-trivial default ctor

    * Adjust `Ignore` linked issue

commit b16e809
Author: Stefan <[email protected]>
Date:   Fri Oct 20 18:54:58 2023 +0200

    Introduce `GenerateFreeStandingFunctionsClassName` option (mono#1782)

    * Introduce `GenerateFreeStandingFunctionsClassName` option

    * Support CLI and fixes

commit 03874e7
Author: Stefan <[email protected]>
Date:   Thu Oct 19 17:24:55 2023 +0200

    Fix Value Type String Member Invalid Codegen (mono#1778)

    * Fix code generation

    * Generate exception on broken struct set op

    * Remove redundant usings

commit adffc99
Author: Salvage <[email protected]>
Date:   Thu Oct 19 14:51:06 2023 +0200

    Fix erroneous newline

commit b4f261e
Author: Salvage <[email protected]>
Date:   Thu Oct 19 14:26:00 2023 +0200

    Simplify `IsTemplateParameterType`

commit 28000a1
Author: Salvage <[email protected]>
Date:   Thu Oct 19 01:19:07 2023 +0200

    Fix mono#1251 three parameter equality operator

    - Operators in generic classes do not attempt to generate as extension methods anymore
    - Empty `...Extensions` classes are no longer generated
    - `string` as a template argument is correctly cast
    - `MarshalCharAsManagedChar` option also generates correct casts
    - Suppress warning regarding returning struct field by ref
    - Eliminate some tabs that snuck into the test C++ header

commit d7faf5f
Author: Joao Matos <[email protected]>
Date:   Wed Oct 18 17:39:49 2023 +0100

    Fix SDL_PollEvent generation in the SDL example.

    Fixes mono#978.

    Thanks to @Saalvage.

commit 7f567b6
Author: Salvage <[email protected]>
Date:   Wed Oct 18 18:26:03 2023 +0200

    Fix non-void returning functions with value-type out parameters

    Also fixes indentation

commit 0c60384
Author: Salvage <[email protected]>
Date:   Wed Oct 18 16:49:41 2023 +0200

    Additional bump

commit 0534e33
Author: Salvage <[email protected]>
Date:   Wed Oct 18 16:35:10 2023 +0200

    Bump GH actions versions to solve warnings

commit a6ef9d9
Author: Salvage <[email protected]>
Date:   Wed Oct 18 16:19:42 2023 +0200

    Fix source dir

commit 7e6c492
Author: Salvage <[email protected]>
Date:   Wed Oct 18 16:08:51 2023 +0200

    Test fix broken packages

commit 2a351b7
Author: Joao Matos <[email protected]>
Date:   Wed Oct 18 16:03:36 2023 +0100

    Update our version to 1.1.

commit 20950c5
Author: Salvage <[email protected]>
Date:   Wed Oct 18 04:58:38 2023 +0200

    More stringent test; Fix indentation (of the code itself, not in the generator)

commit ebe6b8a
Author: Salvage <[email protected]>
Date:   Wed Oct 18 04:47:13 2023 +0200

    Fix value type out parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClassTemplateSpecialization missing Parameters property
2 participants