Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Package Packing #1774

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Fix Package Packing #1774

merged 4 commits into from
Oct 18, 2023

Conversation

Saalvage
Copy link
Contributor

Fixes #1773.

The ref folder is missing from the latest nuget package, leading to none of the DLLs being available.

This change stopped the dlls from being copied to the ref folder.

The following warning is also present in the previous build's logs here under Create package:

C:\Program Files\dotnet\sdk\6.0.414\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(221,5): warning NU5128: Some target frameworks declared in the dependencies group of the nuspec and the lib/ref folder do not have exact matches in the other location. Consult the list of actions below: [D:\a\CppSharp\CppSharp\src\Package\CppSharp.Package.csproj]
C:\Program Files\dotnet\sdk\6.0.414\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(221,5): warning NU5128: - Add lib or ref assemblies for the net6.0 target framework [D:\a\CppSharp\CppSharp\src\Package\CppSharp.Package.csproj]

This warning is no longer present after this fix.

I've also taken the liberty of bumping the version number of a few GH actions in order to fix another CI warning seen here.

@tritao
Copy link
Collaborator

tritao commented Oct 18, 2023

Good find, IIRC I was having build errors on CI with those lines, and after asking @josetr we figured maybe it's not needed anymore and removed it. My bad.

And maybe the version mismatch comes from this: https://github.com/mono/CppSharp/blob/main/version.json#L3

@tritao
Copy link
Collaborator

tritao commented Oct 18, 2023

@Saalvage Can you update the version on that file to 1.1 as part of this PR?

Nevermind, I'll just push it.

@Saalvage
Copy link
Contributor Author

Oh sorry, missed the edit.

@Saalvage
Copy link
Contributor Author

Can confirm, that that does the trick though: https://github.com/Saalvage/CppSharp/actions/runs/6562788582/job/17825554665
(Check ENV after the Set version step)

@tritao
Copy link
Collaborator

tritao commented Oct 18, 2023

Awesome, pushed a new v1.1.1 tag, lets 🙏 it all works now 😄

@Saalvage
Copy link
Contributor Author

On a side note, packages 1.0.76.8341 and 1.1.1.10805 should probably be deprecated on nuget, as they do not work at all.

@tritao
Copy link
Collaborator

tritao commented Oct 18, 2023

On a side note, packages 1.0.76.8341 and 1.1.1.10805 should probably be deprecated on nuget, as they do not work at all.

So the new 1.1.1 does not work yet?

I've been trying to deprecate the broken one on Nuget, but having trouble logging in due to MS account shenanigans.

@tritao
Copy link
Collaborator

tritao commented Oct 18, 2023

Duh, I forgot to merge this...

@tritao tritao merged commit 0c60384 into mono:main Oct 18, 2023
9 checks passed
@Saalvage Saalvage deleted the fix/package-packing branch October 18, 2023 15:27
@Saalvage
Copy link
Contributor Author

Can confirm it's all working now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest Nuget package appears to be broken
2 participants