-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Package Packing #1774
Fix Package Packing #1774
Conversation
Good find, IIRC I was having build errors on CI with those lines, and after asking @josetr we figured maybe it's not needed anymore and removed it. My bad. And maybe the version mismatch comes from this: https://github.com/mono/CppSharp/blob/main/version.json#L3 |
@Saalvage Can you update the version on that file to 1.1 as part of this PR? Nevermind, I'll just push it. |
Oh sorry, missed the edit. |
Can confirm, that that does the trick though: https://github.com/Saalvage/CppSharp/actions/runs/6562788582/job/17825554665 |
31aba78
to
0aca858
Compare
Awesome, pushed a new v1.1.1 tag, lets 🙏 it all works now 😄 |
On a side note, packages 1.0.76.8341 and 1.1.1.10805 should probably be deprecated on nuget, as they do not work at all. |
So the new 1.1.1 does not work yet? I've been trying to deprecate the broken one on Nuget, but having trouble logging in due to MS account shenanigans. |
Duh, I forgot to merge this... |
Can confirm it's all working now! |
Fixes #1773.
The
ref
folder is missing from the latest nuget package, leading to none of the DLLs being available.This change stopped the dlls from being copied to the ref folder.
The following warning is also present in the previous build's logs here under
Create package
:This warning is no longer present after this fix.
I've also taken the liberty of bumping the version number of a few GH actions in order to fix another CI warning seen here.