refactor: refactor controllers (#33)

monicahq · Feb 17, 2024 · 2f60cbd · 2f60cbd
1 parent 849979b
commit 2f60cbd
Show file tree

Hide file tree

Showing 16 changed files with 134 additions and 226 deletions.
diff --git a/app/Http/Controllers/Auth/NewPasswordController.php b/app/Http/Controllers/Auth/NewPasswordController.php
@@ -14,6 +14,8 @@
 
 class NewPasswordController extends Controller
 {
+    use PasswordValidationRules;
+
     /**
      * Display the password reset view.
      */
@@ -32,7 +34,7 @@ public function store(Request $request): RedirectResponse
         $request->validate([
             'token' => ['required'],
             'email' => ['required', 'email'],
-            'password' => ['required', 'confirmed', Rules\Password::defaults()],
+            'password' => $this->passwordRules(),
         ]);
 
         // Here we will attempt to reset the user's password. If it is successful we

diff --git a/app/Http/Controllers/Auth/PasswordController.php b/app/Http/Controllers/Auth/PasswordController.php
@@ -10,14 +10,16 @@
 
 class PasswordController extends Controller
 {
+    use PasswordValidationRules;
+
     /**
      * Update the user's password.
      */
     public function update(Request $request): RedirectResponse
     {
         $validated = $request->validateWithBag('updatePassword', [
             'current_password' => ['required', 'current_password'],
-            'password' => ['required', Password::defaults(), 'confirmed'],
+            'password' => $this->passwordRules(),
         ]);
 
         $request->user()->update([

diff --git a/app/Http/Controllers/Auth/PasswordValidationRules.php b/app/Http/Controllers/Auth/PasswordValidationRules.php
@@ -0,0 +1,18 @@
+<?php
+
+namespace App\Http\Controllers\Auth;
+
+use Illuminate\Validation\Rules\Password;
+
+trait PasswordValidationRules
+{
+    /**
+     * Get the validation rules used to validate passwords.
+     *
+     * @return array<int, \Illuminate\Contracts\Validation\Rule|array|string>
+     */
+    protected function passwordRules(): array
+    {
+        return ['required', 'string', Password::default(), 'confirmed'];
+    }
+}
diff --git a/app/Http/Controllers/Auth/RegisteredUserController.php b/app/Http/Controllers/Auth/RegisteredUserController.php
@@ -10,11 +10,14 @@
 use Illuminate\Http\RedirectResponse;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Auth;
+use Illuminate\Validation\Rule;
 use Illuminate\Validation\Rules;
 use Illuminate\View\View;
 
 class RegisteredUserController extends Controller
 {
+    use PasswordValidationRules;
+
     /**
      * Display the registration view.
      */
@@ -31,8 +34,14 @@ public function create(): View
     public function store(Request $request): RedirectResponse
     {
         $request->validate([
-            'email' => ['required', 'string', 'lowercase', 'email', 'max:255', 'unique:' . User::class],
-            'password' => ['required', 'confirmed', Rules\Password::defaults()],
+            'email' => [
+                'required',
+                'string',
+                'email',
+                'max:255',
+                Rule::unique(User::class)
+            ],
+            'password' => $this->passwordRules(),
         ]);
 
         $user = (new CreateAccount(

diff --git a/app/Http/Controllers/FavoriteController.php b/app/Http/Controllers/FavoriteController.php
@@ -13,9 +13,7 @@ class FavoriteController extends Controller
 {
     public function index(): View
     {
-        $favorites = Cache::remember('user-favorites-details-' . auth()->id(), 604800, function () {
-            return UserViewModel::index();
-        });
+        $favorites = Cache::remember('user-favorites-details-' . auth()->id(), 604800, fn () => UserViewModel::index());
 
         return view('user.index', [
             'names' => $favorites['names'],

diff --git a/app/Http/Controllers/FemaleNameController.php b/app/Http/Controllers/FemaleNameController.php
@@ -19,31 +19,23 @@ public function index(Request $request): View
         // get the page parameter from the url
         $requestedPage = $request->query('page') ?? 1;
 
-        $letters = Cache::remember('all-letters-female', 604800, function () {
-            return FemaleNamesViewModel::index();
-        });
+        $letters = Cache::remember('all-letters-female', 604800, fn () => FemaleNamesViewModel::index());
 
-        Paginator::currentPageResolver(function () use ($requestedPage) {
-            return $requestedPage;
-        });
+        Paginator::currentPageResolver(fn () => $requestedPage);
 
-        $namesPagination = Cache::remember('all-names-female-page-' . $requestedPage, 604800, function () {
-            return Name::where('name', '!=', '_PRENOMS_RARES')
+        $namesPagination = Cache::remember('all-names-female-page-' . $requestedPage, 604800, fn () =>
+            Name::where('name', '!=', '_PRENOMS_RARES')
                 ->where('gender', 'female')
                 ->orderBy('total', 'desc')
-                ->paginate(40);
-        });
+                ->paginate(40)
+        );
 
         $names = $namesPagination
             ->map(fn (Name $name) => NameViewModel::summary($name));
 
-        if (! auth()->check()) {
-            $favoritedNamesForLoggedUser = collect();
-        } else {
-            $favoritedNamesForLoggedUser = Cache::remember('user-favorites-' . auth()->id(), 604800, function () {
-                return UserViewModel::favorites();
-            });
-        }
+        $favoritedNamesForLoggedUser = auth()->check()
+            ? Cache::remember('user-favorites-' . auth()->id(), 604800, fn () => UserViewModel::favorites())
+            : collect();
 
         return view('names.female.index', [
             'letters' => $letters,
@@ -58,32 +50,24 @@ public function letter(Request $request): View
         $requestedLetter = $request->attributes->get('letter');
         $requestedPage = $request->query('page') ?? 1;
 
-        $letters = Cache::remember('all-letters-female', 604800, function () {
-            return FemaleNamesViewModel::index();
-        });
+        $letters = Cache::remember('all-letters-female', 604800, fn () => FemaleNamesViewModel::index());
 
-        Paginator::currentPageResolver(function () use ($requestedPage) {
-            return $requestedPage;
-        });
+        Paginator::currentPageResolver(fn () => $requestedPage);
 
-        $namesPagination = Cache::remember('female-letter-' . $requestedLetter . '-page-' . $requestedPage, 604800, function () use ($requestedLetter) {
-            return Name::where('name', '!=', '_PRENOMS_RARES')
+        $namesPagination = Cache::remember('female-letter-' . $requestedLetter . '-page-' . $requestedPage, 604800, fn () =>
+            Name::where('name', '!=', '_PRENOMS_RARES')
                 ->where('gender', 'female')
                 ->where('name', 'like', $requestedLetter . '%')
                 ->orderBy('total', 'desc')
-                ->paginate(40);
-        });
+                ->paginate(40)
+        );
 
         $names = $namesPagination
             ->map(fn (Name $name) => NameViewModel::summary($name));
 
-        if (! auth()->check()) {
-            $favoritedNamesForLoggedUser = collect();
-        } else {
-            $favoritedNamesForLoggedUser = Cache::remember('user-favorites-' . auth()->id(), 604800, function () {
-                return UserViewModel::favorites();
-            });
-        }
+        $favoritedNamesForLoggedUser = auth()->check()
+            ? Cache::remember('user-favorites-' . auth()->id(), 604800, fn () => UserViewModel::favorites())
+            : collect();
 
         return view('names.female.letter', [
             'letters' => $letters,

diff --git a/app/Http/Controllers/HomeController.php b/app/Http/Controllers/HomeController.php
@@ -11,25 +11,15 @@ class HomeController extends Controller
 {
     public function index(): View
     {
-        $popularNames = Cache::remember('popular-names', 86400, function () {
-            return HomeViewModel::twentyMostPopularNames();
-        });
+        $popularNames = Cache::remember('popular-names', 86400, fn () => HomeViewModel::twentyMostPopularNames());
 
-        $stats = Cache::remember('stats', 604800, function () {
-            return HomeViewModel::serverStats();
-        });
+        $stats = Cache::remember('stats', 604800, fn () => HomeViewModel::serverStats());
 
-        if (! auth()->check()) {
-            $favoritedNamesForLoggedUser = collect();
-        } else {
-            $favoritedNamesForLoggedUser = Cache::remember('user-favorites-' . auth()->id(), 604800, function () {
-                return UserViewModel::favorites();
-            });
-        }
+        $favoritedNamesForLoggedUser = auth()->check()
+            ? Cache::remember('user-favorites-' . auth()->id(), 604800, fn () => UserViewModel::favorites())
+            : collect();
 
-        $lists = Cache::remember('admin-lists', 604800, function () {
-            return HomeViewModel::adminLists();
-        });
+        $lists = Cache::remember('admin-lists', 604800, fn () => HomeViewModel::adminLists());
 
         return view('home.index', [
             'twentyMostPopularNames' => $popularNames,

diff --git a/app/Http/Controllers/ListController.php b/app/Http/Controllers/ListController.php
@@ -14,9 +14,7 @@ class ListController extends Controller
 {
     public function index(): View
     {
-        $lists = Cache::remember('user-lists-' . auth()->id(), 604800, function () {
-            return ListViewModel::index();
-        });
+        $lists = Cache::remember('user-lists-' . auth()->id(), 604800, fn () => ListViewModel::index());
 
         return view('user.lists.index', [
             'lists' => $lists['lists'],
@@ -44,9 +42,7 @@ public function show(Request $request): View
     {
         $requestedList = $request->attributes->get('list');
 
-        $details = Cache::remember('list-details-' . $requestedList->id, 604800, function () use ($requestedList) {
-            return ListViewModel::show($requestedList);
-        });
+        $details = Cache::remember('list-details-' . $requestedList->id, 604800, fn () => ListViewModel::show($requestedList));
 
         return view('user.lists.show', [
             'term' => null,

diff --git a/app/Http/Controllers/ListNameController.php b/app/Http/Controllers/ListNameController.php
@@ -16,9 +16,7 @@ public function index(Request $request): View
     {
         $requestedList = $request->attributes->get('list');
 
-        $details = Cache::remember('list-details-' . $requestedList->id, 604800, function () use ($requestedList) {
-            return ListViewModel::show($requestedList);
-        });
+        $details = Cache::remember('list-details-' . $requestedList->id, 604800, fn () => ListViewModel::show($requestedList));
 
         return view('user.lists.show', [
             'list' => $details,

diff --git a/app/Http/Controllers/ListSearchController.php b/app/Http/Controllers/ListSearchController.php
@@ -14,9 +14,7 @@ public function index(Request $request): View
     {
         $requestedList = $request->attributes->get('list');
 
-        $details = Cache::remember('list-details-' . $requestedList->id, 604800, function () use ($requestedList) {
-            return ListViewModel::show($requestedList);
-        });
+        $details = Cache::remember('list-details-' . $requestedList->id, 604800, fn () => ListViewModel::show($requestedList));
 
         $names = SearchViewModel::names($request->input('term'));
 

diff --git a/app/Http/Controllers/MaleNameController.php b/app/Http/Controllers/MaleNameController.php
@@ -19,31 +19,23 @@ public function index(Request $request): View
         // get the page parameter from the url
         $requestedPage = $request->query('page') ?? 1;
 
-        $letters = Cache::remember('all-letters-male', 604800, function () {
-            return MaleNamesViewModel::index();
-        });
+        $letters = Cache::remember('all-letters-male', 604800, fn () => MaleNamesViewModel::index());
 
-        Paginator::currentPageResolver(function () use ($requestedPage) {
-            return $requestedPage;
-        });
+        Paginator::currentPageResolver(fn () => $requestedPage);
 
-        $namesPagination = Cache::remember('all-names-male-page-' . $requestedPage, 604800, function () {
-            return Name::where('name', '!=', '_PRENOMS_RARES')
+        $namesPagination = Cache::remember('all-names-male-page-' . $requestedPage, 604800, fn () =>
+            Name::where('name', '!=', '_PRENOMS_RARES')
                 ->where('gender', 'male')
                 ->orderBy('total', 'desc')
-                ->paginate(40);
-        });
+                ->paginate(40)
+        );
 
         $names = $namesPagination
             ->map(fn (Name $name) => NameViewModel::summary($name));
 
-        if (! auth()->check()) {
-            $favoritedNamesForLoggedUser = collect();
-        } else {
-            $favoritedNamesForLoggedUser = Cache::remember('user-favorites-' . auth()->id(), 604800, function () {
-                return UserViewModel::favorites();
-            });
-        }
+        $favoritedNamesForLoggedUser = auth()->check()
+            ? Cache::remember('user-favorites-' . auth()->id(), 604800, fn () => UserViewModel::favorites())
+            : collect();
 
         return view('names.male.index', [
             'letters' => $letters,
@@ -58,32 +50,24 @@ public function letter(Request $request): View
         $requestedLetter = $request->attributes->get('letter');
         $requestedPage = $request->query('page') ?? 1;
 
-        $letters = Cache::remember('all-letters-male', 604800, function () {
-            return MaleNamesViewModel::index();
-        });
+        $letters = Cache::remember('all-letters-male', 604800, fn () => MaleNamesViewModel::index());
 
-        Paginator::currentPageResolver(function () use ($requestedPage) {
-            return $requestedPage;
-        });
+        Paginator::currentPageResolver(fn () => $requestedPage);
 
-        $namesPagination = Cache::remember('male-letter-' . $requestedLetter . '-page-' . $requestedPage, 604800, function () use ($requestedLetter) {
-            return Name::where('name', '!=', '_PRENOMS_RARES')
+        $namesPagination = Cache::remember('male-letter-' . $requestedLetter . '-page-' . $requestedPage, 604800, fn () =>
+            Name::where('name', '!=', '_PRENOMS_RARES')
                 ->where('gender', 'male')
                 ->where('name', 'like', $requestedLetter . '%')
                 ->orderBy('total', 'desc')
-                ->paginate(40);
-        });
+                ->paginate(40)
+        );
 
         $names = $namesPagination
             ->map(fn (Name $name) => NameViewModel::summary($name));
 
-        if (! auth()->check()) {
-            $favoritedNamesForLoggedUser = collect();
-        } else {
-            $favoritedNamesForLoggedUser = Cache::remember('user-favorites-' . auth()->id(), 604800, function () {
-                return UserViewModel::favorites();
-            });
-        }
+        $favoritedNamesForLoggedUser = auth()->check()
+            ? Cache::remember('user-favorites-' . auth()->id(), 604800, fn () => UserViewModel::favorites())
+            : collect();
 
         return view('names.male.letter', [
             'letters' => $letters,