Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Disable Signups for new users #7254

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: Disable Signups for new users #7254

wants to merge 10 commits into from

Conversation

davpsh
Copy link

@davpsh davpsh commented May 2, 2024

These changes allow to enable/disable new user registration based on ENV setting. The feature was implemented in version 4.x and was not present in chandler. Fixes #6687

Changes:

  • added new environment parameter APP_DISABLE_SIGNUP
  • restricting registration access based on env setting value

@CLAassistant
Copy link

CLAassistant commented May 2, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@davpsh davpsh mentioned this pull request May 2, 2024
Open
davpsh
davpsh commented May 2, 2024
View reviewed changes
lang/en/auth.php Outdated Show resolved Hide resolved
asbiin
asbiin requested changes May 4, 2024
View reviewed changes
Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the work.
However it is a little bit more complicated than needed, please see my reviews.

app/Helpers/SignupHelper.php Outdated Show resolved Hide resolved
app/Http/Controllers/Auth/LoginController.php Outdated Show resolved Hide resolved
app/Http/Middleware/EnsureSignupIsEnabled.php Outdated Show resolved Hide resolved
app/Http/Middleware/EnsureSignupIsEnabled.php Outdated Show resolved Hide resolved
phpunit.xml Outdated Show resolved Hide resolved
tests/Feature/Auth/RegistrationTest.php Show resolved Hide resolved
app/Providers/FortifyServiceProvider.php Outdated Show resolved Hide resolved
@davpsh davpsh changed the title Issue 6687: Disable Signups for new users feat: Disable Signups for new users May 8, 2024
@davpsh davpsh requested a review from asbiin May 8, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asbiin asbiin Awaiting requested review from asbiin

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How do disable Signups for new users?
3 participants
@davpsh @CLAassistant @asbiin