Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: migration 2017_01_28_222114_remove_viewed_at_from_contacts #6963

Merged
merged 2 commits into from
Oct 31, 2023
Merged

fix: migration 2017_01_28_222114_remove_viewed_at_from_contacts #6963

merged 2 commits into from
Oct 31, 2023

Conversation

JensGryspeert
Copy link
Contributor

Issue #6960

@CLAassistant
Copy link

CLAassistant commented Oct 27, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@JensGryspeert JensGryspeert changed the title Enhance Robustness of RemoveViewedAtFromContacts Migration fix: migration 2017_01_28_222114_remove_viewed_at_from_contacts Oct 27, 2023
asbiin
asbiin requested changes Oct 28, 2023
View reviewed changes
Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. See my comment

database/migrations/2017_01_28_222114_remove_viewed_at_from_contacts.php Outdated Show resolved Hide resolved
database/migrations/2017_01_28_222114_remove_viewed_at_from_contacts.php Outdated Show resolved Hide resolved
@JensGryspeert JensGryspeert force-pushed the bugfix/6960/fix-migration-remove-viewed-at-migrations branch from e138b0f to 15aa483 Compare October 28, 2023 21:29
@JensGryspeert
Copy link
Contributor Author

Thanks. See my comment

I squashed the modifications. The reason I work with early returns is to avoid if nesting in bigger code pages - to used at it haha sorry.

asbiin
asbiin requested changes Oct 28, 2023
View reviewed changes
Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've missed this issue the first time ->

database/migrations/2017_01_28_222114_remove_viewed_at_from_contacts.php Outdated Show resolved Hide resolved
database/migrations/2017_01_28_222114_remove_viewed_at_from_contacts.php Outdated Show resolved Hide resolved
@asbiin asbiin merged commit ff22463 into monicahq:4.x Oct 31, 2023
18 of 19 checks passed
@asbiin asbiin mentioned this pull request Nov 7, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asbiin asbiin asbiin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JensGryspeert @CLAassistant @asbiin