-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Ruby 3.2 #53
Support Ruby 3.2 #53
Conversation
I got the following error to run `bundle install` with Ruby 3.2.2. > listen-3.2.1 requires ruby version >= 2.2.7, ~> 2.2, which is > incompatible with the current version, ruby 3.2.2p53
I got the following error while running `bundle exec rake`. > /Users/masato/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.9.2/exe/rspec: warning: Exception in finalizer #<Proc:0x000000010488e6b8 /Users/masato/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/mongo-2.13.0/lib/mongo/server.rb:285> > /Users/masato/.rbenv/versions/3.2.2/lib/ruby/3.2.0/timeout.rb:101:in `new': can't alloc thread (ThreadError)
@@ -31,14 +31,14 @@ GEM | |||
guard (~> 2.1) | |||
guard-compat (~> 1.1) | |||
rspec (>= 2.99.0, < 4.0) | |||
listen (3.2.1) | |||
listen (3.8.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got the following error to run bundle install
with Ruby 3.2.2.
listen-3.2.1 requires ruby version >= 2.2.7, ~> 2.2, which is
incompatible with the current version, ruby 3.2.2p53
So I update listen gem with the following command.
$ bundle update listen --conservative
rb-fsevent (~> 0.10, >= 0.10.3) | ||
rb-inotify (~> 0.9, >= 0.9.10) | ||
log_buddy (0.7.0) | ||
lumberjack (1.2.8) | ||
method_source (1.0.0) | ||
mongo (2.13.0) | ||
bson (>= 4.8.2, < 5.0.0) | ||
mongo (2.19.3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got the following error while running bundle exec rake
.
/Users/masato/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rspec-core-3.9.2/exe/rspec: warning: Exception in finalizer #<Proc:0x000000010488e6b8 /
+Users/masato/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/mongo-2.13.0/lib/mongo/server.rb:285>
/Users/masato/.rbenv/versions/3.2.2/lib/ruby/3.2.0/timeout.rb:101:in `new': can't alloc thread (ThreadError)
So I updated mongo gem with the following command.
$ bundle update mongo --conservative
I titled this PR "Support Ruby 3.2", but it can be misleading. |
I added Ruby 3.2.2 to the CI matrix.
In addition, I updated some gems in Gemfile.lock to run spec locally with Ruby 3.2.2.
(EDIT)
We don't have to release a new version to support Ruby 3.2. There are no changes in plucky's implementation.