-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Supports new networking
attribute in mongodbatlas_stream_connection
#2474
base: master
Are you sure you want to change the base?
Conversation
APIx bot: a message has been sent to Docs Slack channel |
internal/service/streamconnection/data_source_stream_connection_test.go
Outdated
Show resolved
Hide resolved
internal/service/streamconnection/resource_stream_connection_migration_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leaving suggestions but in general LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Waiting to merge this until stream_connection is not created by default when creating a stream_instance |
This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy! |
@@ -65,6 +66,10 @@ func testCaseKafkaPlaintext(t *testing.T) *resource.TestCase { | |||
}, | |||
} | |||
} | |||
func DummySleep(*terraform.State) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge blocker: Getting 500s when a stream connection changes networking to VPC and is deleted straight afterwards. Detailed Jira Ticket
Merge blocked by upstream breaking change, wait for this and remove |
This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy! |
…until blocked issue is resolved)
Description
Supports new
networking
attribute inmongodbatlas_stream_connection
This attribute is only used when type of connection is Kafka.
Attribute is Computed and Optional. This is because it can be set by the user but it also has a default value if is not set by the user and is always returned by the API.
Link to any related issue(s): CLOUDP-265074
Type of change:
Required Checklist:
Further comments