Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Includes GH actions dependency review in PR checks #1894

Closed
wants to merge 1 commit into from

Conversation

AgustinBettati
Copy link
Member

Description

We have this action in our CFN repository but was missing here.

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@AgustinBettati AgustinBettati requested a review from a team as a code owner January 31, 2024 10:49
@AgustinBettati
Copy link
Member Author

Will wait to merge as we saw a false positive raised in CFN repository PR, raised an issue to the dependency-review-action to get more clarity: actions/dependency-review-action#676.

@@ -70,6 +70,14 @@ jobs:
go-version-file: 'go.mod'
- name: website lint
run: make tools && make website-lint
dependency-review:
runs-on: ubuntu-latest
if: ${{ github.event_name == 'pull_request' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if: ${{ github.event_name == 'pull_request' }}

I would remove the check for pr and will do always, e.g. why not do it if workflow_dispatch?

Copy link
Member

@lantoli lantoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx! is it in cdk repo as well?

Copy link
Contributor

github-actions bot commented Feb 6, 2024

This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!

@github-actions github-actions bot added the stale label Feb 6, 2024
@lantoli lantoli added not_stale Not stale issue or PR and removed stale labels Feb 6, 2024
@AgustinBettati
Copy link
Member Author

Closing this PR for now, actions/dependency-review-action#676 confirmed that this action is not able to infer the proper ordering of pinned GitHub Actions versions so this will likely bring up false positives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not_stale Not stale issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants