-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Includes GH actions dependency review in PR checks #1894
Conversation
Will wait to merge as we saw a false positive raised in CFN repository PR, raised an issue to the dependency-review-action to get more clarity: actions/dependency-review-action#676. |
@@ -70,6 +70,14 @@ jobs: | |||
go-version-file: 'go.mod' | |||
- name: website lint | |||
run: make tools && make website-lint | |||
dependency-review: | |||
runs-on: ubuntu-latest | |||
if: ${{ github.event_name == 'pull_request' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if: ${{ github.event_name == 'pull_request' }} | |
I would remove the check for pr and will do always, e.g. why not do it if workflow_dispatch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx! is it in cdk repo as well?
This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy! |
Closing this PR for now, actions/dependency-review-action#676 confirmed that this action is not able to infer the proper ordering of pinned GitHub Actions versions so this will likely bring up false positives. |
Description
We have this action in our CFN repository but was missing here.
Type of change:
Required Checklist:
Further comments