remove clean connectionCheckout timeout #4274
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Warren James <[email protected]>
Co-authored-by: Bailey Pearson <[email protected]>
Co-authored-by: Neal Beeken <[email protected]> Co-authored-by: Bailey Pearson <[email protected]>
Co-authored-by: Neal Beeken <[email protected]>
…4243) Co-authored-by: Warren James <[email protected]> Co-authored-by: Neal Beeken <[email protected]> Co-authored-by: Bailey Pearson <[email protected]>
baileympearson
commented
Oct 11, 2024
| }); | ||
| } | ||
|
|
||
| export function isCSOTTimeoutContext( |
There was a problem hiding this comment.
Having a method that narrows the base abstraction to a concrete subtype as a required method on the base abstraction breaks the base abstraction. I've moved this to a floating function to keep the abstraction clean.
baileympearson
commented
Oct 11, 2024
| @@ -180,20 +180,14 @@ export abstract class TimeoutContext { | |||
|
|
|||
| abstract get maxTimeMS(): number | null; | |||
|
|
|||
| abstract get serverSelectionTimeout(): Timeout | null; | |||
| abstract get timeoutForServerSelection(): Timeout | null; | |||
There was a problem hiding this comment.
half of our timeout methods were timeoutFor<x> and the other half were <x>Timeout. I've aligned them all to timeoutFor<x>.
baileympearson
force-pushed
the
NODE-6090
branch
2 times, most recently
from
c3f31da
to
4fd4b24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ver selection### Description
What is changing?
Is there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript