task: update documentation for golang #3338
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Updating documentation to cover golang version requirement ## Reason ``` Building atlas binary go build -ldflags "-s -w -X github.com/mongodb/mongodb-atlas-cli/atlascli/internal/version.GitCommit=436cdc259407d225f622e5a407a43e43f4070d99 -X github.com/mongodb/mongodb-atlas-cli/atlascli/internal/version.Version=1.19.0-374-g436cdc259" -o ./bin/atlas ./cmd/atlas go: go.mod requires go >= 1.23.1 (running go 1.21.3; GOTOOLCHAIN=local) make: *** [build] Error 1 ``` ## Separate concern Go.mod file does not use toolchain directive which can automatically request proper golang version to be used. Since I moved from Atlas CLI I noticed we no longer use adsf tools definitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating documentation to cover golang version requirement
Reason
Separate concern
Go.mod file does not use toolchain directive which can automatically request proper golang version for build purposes.
Do we have any reason to not define tooling directive?
Since I moved from Atlas CLI dev I noticed we no longer use adsf tools definitions.