Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-278461: Kubernetes Operator - Fixed Serverless PE export for GCP provider #3333

Merged
merged 4 commits into from
Oct 21, 2024
Merged

CLOUDP-278461: Kubernetes Operator - Fixed Serverless PE export for GCP provider #3333

merged 4 commits into from
Oct 21, 2024

Conversation

igor-karpukhin
Copy link
Contributor

Proposed changes

Fixed the error when exporting a serverless instance on GCP, because of unsupported PE for GCP.

Jira ticket: CLOUDP-278461

Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

josvazg
josvazg previously approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igor-karpukhin igor-karpukhin marked this pull request as ready for review October 21, 2024 12:46
@igor-karpukhin igor-karpukhin requested a review from a team as a code owner October 21, 2024 12:46
@igor-karpukhin igor-karpukhin merged commit 436cdc2 into master Oct 21, 2024
20 checks passed
@igor-karpukhin igor-karpukhin deleted the CLOUDP-278461/fix-serverless-pe-export branch October 21, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josvazg josvazg josvazg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igor-karpukhin @josvazg