CLOUDP-277610: [AtlasCLI] Clusters watch is broken when using atlas upgrade #3314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmenezes
previously approved these changes
Oct 9, 2024
fmenezes
approved these changes
Oct 9, 2024
fmenezes
reviewed
Oct 9, 2024
| @@ -106,7 +106,8 @@ func (logLine *AuditLogLine) logAdditionalAuthData() []byte { | |||
| const AADByteSize = 8 | |||
|
|
|||
| additionalAuthData := make([]byte, AADByteSize) | |||
| binary.LittleEndian.PutUint64(additionalAuthData, uint64(logLine.TS.UnixMilli())) //nolint:gosec | |||
| //nolint:gosec | |||
There was a problem hiding this comment.
Because of the go-linter. I don't know how it sneaked into master.
There was a problem hiding this comment.
I meant the //nolint:gosec was already there you seemed to have moved it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
atlas cluster watchdoes not return a404after runningatlas cluster upgrade.However, I did encounter a
401because the bearer token expires within the time that the cluster is done upgrading.Proposed changes
Jira ticket: CLOUDP-277610