Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-275155: [AtlasCLI] Update Go SDK: Add support for pinned versions #3279

Merged
merged 6 commits into from
Sep 24, 2024
Merged

CLOUDP-275155: [AtlasCLI] Update Go SDK: Add support for pinned versions #3279

merged 6 commits into from
Sep 24, 2024

Conversation

jeroenvervaeke
Copy link
Collaborator

@jeroenvervaeke jeroenvervaeke commented Sep 24, 2024 •
edited
Loading

Proposed changes

This is the automated Go SDK update + pinning clusters to the existing version.

Changes I had to make to make this work:

  • Import both versions of SDK
  • Add a pinned cluster client to the store
  • Disable SDK auto update workflow because it keeps overriding the pinned version (for now, this will be fixed in https://jira.mongodb.org/browse/CLOUDP-275155)

Jira ticket: CLOUDP-275155

I have scheduled ALL tasks on evergreen.

@jeroenvervaeke jeroenvervaeke requested review from a team as code owners September 24, 2024 09:41
blva
blva approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@blva blva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if LGTEV

andreaangiolillo
andreaangiolillo approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeroenvervaeke jeroenvervaeke merged commit 4a61b27 into master Sep 24, 2024
34 checks passed
@jeroenvervaeke jeroenvervaeke deleted the CLOUDP-267253 branch September 24, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

@blva blva blva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeroenvervaeke @andreaangiolillo @blva @wtrocki