CLOUDP-202283: print warning for unsupported distros #2327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blva
commented
Oct 3, 2023
| case "darwin": | ||
| // MacOS Intel and M1 are supported | ||
| return true | ||
| case "windows": |
There was a problem hiding this comment.
this should avoid that we use sysinfo for windows machines, but there is a test failure I'm investigating
There was a problem hiding this comment.
updated with a more known library
There was a problem hiding this comment.
Local deployment tests are failing. It seems that is printing OS not supported for rhel
deployments_local_test.go:118:
[2023/10/03 13:23:15.981] Error Trace: /data/mci/ba99dbf9685aecc06f0fc28d64e7772e/src/github.com/mongodb/mongodb-atlas-cli/test/e2e/atlas/deployments_local_test.go:118
[2023/10/03 13:23:15.981] Error: Not equal:
[2023/10/03 13:23:15.981] expected: "NAME TYPE MDB VER STATE\ntest LOCAL 7.0.1 IDLE\n"
[2023/10/03 13:23:15.981] actual : "Local deployments are not supported on this OS, to see local deployments requirements visit https://www.mongodb.com/docs/atlas/cli/stable/atlas-cli-deploy-local/.\nNAME TYPE MDB VER STATE\ntest LOCAL 7.0.1 IDLE\n"
[2023/10/03 13
andreaangiolillo
previously approved these changes
Oct 3, 2023
blva
commented
Oct 3, 2023
|
|
||
| func (opts *DeploymentOpts) LocalDeploymentPreRun(ctx context.Context) error { | ||
| if !localDeploymentSupportedByOs() { | ||
| _, _ = log.Warningln("Local deployments are not supported on this OS, to see local deployments requirements visit https://www.mongodb.com/docs/atlas/cli/stable/atlas-cli-deploy-local/.") |
There was a problem hiding this comment.
@mongodb/docs-cloud-team asking for review here
zach-carr
previously approved these changes
Oct 4, 2023
|
|
||
| func (opts *DeploymentOpts) LocalDeploymentPreRun(ctx context.Context) error { | ||
| if !localDeploymentSupportedByOs() { | ||
| _, _ = log.Warningln("Local deployments are not supported on this OS, to see local deployments requirements visit https://www.mongodb.com/docs/atlas/cli/stable/atlas-cli-deploy-local/.") |
andreaangiolillo
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-202283
Notes:
Ubuntu test
Checklist
make fmtand formatted my codeFurther comments