Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-195032: Fix container tagging #2156

Merged
merged 1 commit into from
Aug 14, 2023
Merged

CLOUDP-195032: Fix container tagging #2156

merged 1 commit into from
Aug 14, 2023

Conversation

nicohrubec
Copy link
Contributor

@nicohrubec nicohrubec commented Aug 14, 2023 •
edited
Loading

Proposed changes

Previously the version tag for the Atlas CLI docker container was retrieved from the latest release. Since both Mongo and Atlas CLI are released from this repository, this does not work. This changes this behaviour to retrieve the version tag by filtering the tags for the latest AtlasCLI tag.

Successful test run: https://github.com/mongodb/mongodb-atlas-cli/actions/runs/5854968916/job/15871869126

Jira ticket: CLOUDP-195032

Closes CLOUDP-195032

@nicohrubec nicohrubec marked this pull request as ready for review August 14, 2023 11:25
@nicohrubec nicohrubec requested a review from a team August 14, 2023 11:25
matt-condon
matt-condon approved these changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@matt-condon matt-condon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicohrubec nicohrubec merged commit 5d6345b into master Aug 14, 2023
13 checks passed
@nicohrubec nicohrubec deleted the CLOUDP-195032 branch August 14, 2023 13:07
VincentPikand added a commit that referenced this pull request Aug 16, 2023
@VincentPikand
Squashed commit of the following:
72965a3 
commit d91ca56
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 15 17:31:41 2023 +0100

    fix: add line to E2E `README`

commit 6460a40
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 15 17:24:49 2023 +0100

    fix: remove `constants.go`

commit d378c87
Merge: b74b47e 1d7e821
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 15 17:23:53 2023 +0100

    Merge remote-tracking branch 'origin/master' into CLOUDP-193023

commit 1d7e821
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 15 17:21:29 2023 +0100

    CLOUDP-193346: Add command "atlas backups compliancepolicy enable" L1 support (#2164)

commit b74b47e
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 15 17:21:14 2023 +0100

    fix: lint

commit 499d393
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 15 17:15:24 2023 +0100

    CLOUDP-193023: Made setup test more robust

commit 8f2bf8a
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 15 16:56:57 2023 +0100

    CLOUDP-193023: Adapted Mocks after removing old store.

commit 0f3bd2e
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 15 16:43:50 2023 +0100

    CLOUDP-193023: Adapt `setup` for new E2E tests

commit 44b7bb4
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 15 16:38:34 2023 +0100

    fix: remove newline from `describe`

commit 0baecad
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 15 16:37:50 2023 +0100

    CLOUDP-193023: Adapt `describe` command for new E2E tests

commit 0ba62a6
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 15 16:36:53 2023 +0100

    CLOUDP-193023: adapt copyprotection for new E2E tests

commit c2f030e
Merge: 3f29b9a c9b5ef8
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 15 16:26:19 2023 +0100

    Merge branch 'CLOUDP-193346' into CLOUDP-193023

commit 3f29b9a
Merge: 88de33e 26cac0d
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 15 16:25:57 2023 +0100

    Merge remote-tracking branch 'origin/master' into CLOUDP-193023

commit c9b5ef8
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 15 15:32:06 2023 +0100

    fix: gen mocks

commit 5f91268
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 15 15:09:13 2023 +0100

    fix: builder test

commit e4ada4a
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 15 15:04:47 2023 +0100

    fix: description

commit 86ff2e1
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 15 15:01:37 2023 +0100

    fix: linting, tests

commit 756c177
Merge: 65b2eda 26cac0d
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 15 14:35:14 2023 +0100

    Merge remote-tracking branch 'origin/master' into CLOUDP-193346

commit 65b2eda
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 15 14:34:53 2023 +0100

    CLOUDP-193346: Add E2E test

commit 26cac0d
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 15 14:25:33 2023 +0100

    CLOUDP-193348: Add command "atlas backups compliancepolicy setup" L1 support (#2144)

commit 202f5df
Author: Filipe Constantinov Menezes <[email protected]>
Date:   Tue Aug 15 14:23:00 2023 +0100

    CLOUDP-170540 MongoDB Employee only: Improve error handling in the cli (#2163)

commit 7f7ad47
Merge: 18fbd8a 54eba43
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 15 14:15:10 2023 +0100

    Merge branch 'CLOUDP-193348' into CLOUDP-193346

commit 18fbd8a
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 15 14:14:57 2023 +0100

    CLOUDP-193346: `--watch` and atlas store

commit 54eba43
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 15 13:54:10 2023 +0100

    fix: description of --watch

commit 603fd2b
Author: Vincent Pikand <[email protected]>
Date:   Mon Aug 14 17:52:42 2023 +0100

    CLOUDP-193004: add compliancepolicy endpoints to atlas store

commit e544d10
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 15 13:11:31 2023 +0100

    CLOUDP-193348: handle projectId logic and `--watch`

commit acfa17c
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Aug 15 08:46:19 2023 +0000

    build(deps): bump the google group with 1 update (#2157)

commit 51a00d9
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Aug 15 08:42:25 2023 +0000

    build(deps): bump golangci/golangci-lint-action from 3.6.0 to 3.7.0 (#2162)

commit a1ab147
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Aug 15 08:16:30 2023 +0000

    build(deps): bump cloud.google.com/go/kms from 1.15.0 to 1.15.1 (#2159)

commit b84faf4
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Aug 15 08:16:10 2023 +0000

    build(deps): bump the azure group with 1 update (#2158)

commit 5d6345b
Author: Nicolas Hrubec <[email protected]>
Date:   Mon Aug 14 14:07:54 2023 +0100

    CLOUDP-195032: Fix container tagging (#2156)

commit 1a83687
Author: kanchana-mongodb <[email protected]>
Date:   Fri Aug 11 07:50:10 2023 -0700

    DOCSP-31899 Update docs for Creating an export bucket to s3 (#2147)

    Co-authored-by: Sarah Simpers <[email protected]>

commit bc32873
Author: Gustavo Bazan <[email protected]>
Date:   Fri Aug 11 11:09:39 2023 +0100

    CLOUDP-177520: Start publishing on the server 7.0 repos (#2154)

commit 3ae94b2
Author: Gustavo Bazan <[email protected]>
Date:   Fri Aug 11 11:01:48 2023 +0100

    CLOUDP-194833: Clean up tags (#2155)

commit dfdf26b
Author: Gustavo Bazan <[email protected]>
Date:   Fri Aug 11 10:20:24 2023 +0100

    CLOUDP-194833: Drop support for ops manager 5 (#2153)

commit 74714d3
Author: Gustavo Bazan <[email protected]>
Date:   Fri Aug 11 10:10:55 2023 +0100

    CLOUDP-194831: Fix and validate templates for all cloud provider access commands (#2151)

commit 306e9d7
Author: Vincent Pikand <[email protected]>
Date:   Fri Aug 11 06:26:59 2023 +0100

    fix: remove newline from templates

commit f8297ad
Author: Vincent Pikand <[email protected]>
Date:   Thu Aug 10 15:08:02 2023 +0100

    fix: correct usage message

commit 561911e
Author: Wojciech Trocki <[email protected]>
Date:   Thu Aug 10 16:00:51 2023 +0200

    CLOUDP-192357: automation for creation of jira issues in atlas CLI (#2139)

commit e783c70
Author: kanchana-mongodb <[email protected]>
Date:   Wed Aug 9 15:16:24 2023 -0700

    DOCSP-31836 fix for search index creation is lacking crucial details (#2148)

commit ca417b1
Author: Wojciech Trocki <[email protected]>
Date:   Wed Aug 9 18:54:58 2023 +0200

    CLOUDP-194380: generate stable operations go SDK in atlas CLI (#2146)

commit 88de33e
Author: Vincent Pikand <[email protected]>
Date:   Wed Aug 9 15:07:36 2023 +0100

    CLOUDP-193023: Add E2E test for `copyprotection` and `describe`

commit ebb37f0
Author: Vincent Pikand <[email protected]>
Date:   Wed Aug 9 14:01:34 2023 +0100

    CLOUDP-193348: Change force flag behaviour

commit e9e3a47
Author: Vincent Pikand <[email protected]>
Date:   Wed Aug 9 13:12:52 2023 +0100

    fix: ordering of commands

commit a3275ae
Author: Vincent Pikand <[email protected]>
Date:   Fri Aug 4 16:36:06 2023 +0100

    CLOUDP-193346: Invalid e-mail test

commit 7ce7315
Author: Vincent Pikand <[email protected]>
Date:   Fri Aug 4 16:34:38 2023 +0100

    CLOUDP-193346: Enable command and unit tests

commit 3ba5f4d
Merge: 1377854 349b5a9
Author: Vincent Pikand <[email protected]>
Date:   Fri Aug 4 13:39:04 2023 +0100

    Merge remote-tracking branch 'origin/master' into CLOUDP-193346

commit 1377854
Author: Vincent Pikand <[email protected]>
Date:   Fri Aug 4 13:36:32 2023 +0100

    CLOUDP-193346: Move constants to separate file

commit 90ec40b
Author: Vincent Pikand <[email protected]>
Date:   Fri Aug 4 13:35:50 2023 +0100

    CLOUDP-193346: add `authorizedEmail` flag

commit 2f7e0a1
Author: Vincent Pikand <[email protected]>
Date:   Thu Aug 3 12:22:25 2023 +0100

    fix: comment

commit 4387fd5
Author: Vincent Pikand <[email protected]>
Date:   Thu Aug 3 12:20:41 2023 +0100

    fix: use constant instead of string

commit dd7633e
Author: Vincent Pikand <[email protected]>
Date:   Thu Aug 3 12:18:24 2023 +0100

    fix: slightly incorrect comment

commit dab070d
Author: Vincent Pikand <[email protected]>
Date:   Thu Aug 3 12:16:47 2023 +0100

    fix: add new line to print

commit 5a4165f
Author: Vincent Pikand <[email protected]>
Date:   Thu Aug 3 11:29:20 2023 +0100

    fix: linting

commit 2fcd714
Merge: f7158bd 2d2c2e8
Author: Vincent Pikand <[email protected]>
Date:   Thu Aug 3 10:27:51 2023 +0100

    Merge remote-tracking branch 'origin/master' into CLOUDP-193000

commit f7158bd
Author: Vincent Pikand <[email protected]>
Date:   Thu Aug 3 10:21:37 2023 +0100

    CLOUDP-193000: tests and improved text

commit ea9780d
Author: Vincent Pikand <[email protected]>
Date:   Wed Aug 2 16:34:08 2023 +0100

    CLOUDP-193000: Add store implemention, interface and mocks

commit ad17935
Author: Vincent Pikand <[email protected]>
Date:   Wed Aug 2 16:33:26 2023 +0100

    fix: remove hidden

commit 947f0a0
Author: Vincent Pikand <[email protected]>
Date:   Wed Aug 2 16:33:11 2023 +0100

    CLOUDP-193000: Adapted parent command to reflect copyprotection

commit d68b10e
Author: Vincent Pikand <[email protected]>
Date:   Wed Aug 2 16:32:17 2023 +0100

    CLOUDP-193000: Copy protection

commit ed4f6d9
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 1 17:01:16 2023 +0100

    fix: build tags

commit 43f9943
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 1 16:59:30 2023 +0100

    fix: linting

commit dc607c8
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 1 16:36:14 2023 +0100

    CLOUDP-192999: Add additional tests

commit e771de6
Merge: f479cc7 b1bb1b3
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 1 16:28:12 2023 +0100

    Merge remote-tracking branch 'origin/master' into CLOUDP-192999

commit f479cc7
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 1 16:27:03 2023 +0100

    CLOUDP-192999: Add E2E test

commit 30288c6
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 1 16:24:35 2023 +0100

    fix: make `compliancepolicy` command hidden.

commit 60128e2
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 1 16:24:02 2023 +0100

    CLOUDP-192999: Add `describe` command and tests

commit 8dc5701
Author: Vincent Pikand <[email protected]>
Date:   Tue Aug 1 16:16:08 2023 +0100

    CLOUDP-192999: Add compliancepolicy parent command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

@matt-condon matt-condon matt-condon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicohrubec @gssbzn @matt-condon