Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depends: boost: update to 1.84.0 #9162

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

tobtoht
Copy link
Collaborator

@tobtoht tobtoht commented Feb 12, 2024

@vtnerd
Copy link
Contributor

vtnerd commented Feb 15, 2024

@selsta Should we update the minimum Boost required? The Boost release notes list new libraries with each release. We currently list 1.58 as minimum. Bumping the minimum required allows us to use some newer libraries.

The most interesting libraries are: Boost.Hana (1.61), Boost.Fiber ("green" threads)(1.62), Stacktrace (1.65), Beast (http parsing)(1.66), Boost.Mp11 (1.66), Boost.Outcome (1.70), Boost.Json (1.75), and Boost.Url (1.81).

The Boost versions:

  • Ubuntu 20.04 : 1.71 (EOL April 2025)
  • Debian 10: 1.67 (EOL June 30 2024)
  • Fedora 39: 1.81 (EOL Dec 7 2024)
  • Void: 1.83?
  • Arch: 1.83
  • Gentoo: 1.82

I would recommend Boost 1.66 based on this list (does not include Centos, which is not listed in current documentation).

@selsta
Copy link
Collaborator

selsta commented Feb 15, 2024

I think quite a few people still use Ubuntu 18.04 which seems to have boost 1.65, so I'd prefer nothing newer if possible.

@tobtoht tobtoht marked this pull request as ready for review December 24, 2024 17:36
Copy link
Contributor

@vtnerd vtnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I believe the failing tests are unrelated.

@luigi1111 luigi1111 merged commit 551ce58 into monero-project:master Jan 6, 2025
31 of 32 checks passed
@vtnerd
Copy link
Contributor

vtnerd commented Jan 6, 2025

Should this be posted to the release branch too? This arguably violates the rule of not adding new features to the release branch, otoh the build has to be fixed to <boost 1.87.

@tobtoht
Copy link
Collaborator Author

tobtoht commented Jan 6, 2025

Development builds on the release branch are currently broken on rolling release distros without a #9628 backport, so ideally, yes.

However, iirc we can't update to this version (1.84.0) without breaking Gitian. We might be able to update to 1.66.0 which should be sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants