Set anchors target for external urls to _blank #2118
Conversation
✅ Deploy Preview for barolo-time-757cf9 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
If @erciccione could clarify the scope of this PR ( |
The en folders don't need to be touched in this case as most if not all links are inside the documents themselves. |
|
closes #1921 |
|
@FedericoNembrini there are some conflicts that need to be solved before we can merge this. |
|
I have resolved the merge conflicts, have I forgotten something? |
|
@FedericoNembrini The last commit you pushed is a merge commit. That usually happens after a borked rebase. You could try to remove it and rebase again, fixing the merge conflict. |
|
I have resolved conflicts with github built in function. |
FedericoNembrini
force-pushed
the
set-external-anchor-target
branch
from
418ad78 to
2a9782d
Compare
FedericoNembrini
force-pushed
the
set-external-anchor-target
branch
from
2a9782d to
d01a074
Compare
|
@FedericoNembrini please fix the conflicts and rebase :) |
|
ping @FedericoNembrini |
|
I will fix this in the coming days |
|
there is a plugin which claims to do this automagically for external links. i have not tested it yet but looks promising https://github.com/keithmifsud/jekyll-target-blank |
As discussed in #1921 and #1922, I set the target to
_blankfor links to external sites.I have only modified links that comply with the css rule applied via
a[href^="https:"]:not([href*="getmonero.org"])and which therefore display theexternal.svgicon