⭐🌙 Cloudflare Provider #4743
⭐🌙 Cloudflare Provider #4743
Conversation
slntopp
force-pushed
the
mik/cloudflare-provider
branch
2 times, most recently
from
0ecad60
to
d8e1dfd
Compare
|
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
.github/actions/spelling/expect.txt
Outdated
| @@ -103,4 +105,4 @@ Vtpm | |||
| vulnerabilityassessmentsettings | |||
| vulnmgmt | |||
| wil | |||
| xssmatchstatement | |||
| xssmatchstatement | |||
There was a problem hiding this comment.
If you toss any empty line in these file these will go away
|
Ping @misterpantz for the lr file words |
slntopp
force-pushed
the
mik/cloudflare-provider
branch
from
6ccc07e
to
13b5343
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Thank you @misterpantz |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Letha <[email protected]>
Co-authored-by: Letha <[email protected]>
slntopp
force-pushed
the
mik/cloudflare-provider
branch
from
90a399b
to
5857c05
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| // SPDX-License-Identifier: BUSL-1.1 | ||
| package resources | ||
|
|
||
| func (c *mqlCloudflareZone) id() (string, error) { |
There was a problem hiding this comment.
this is not going to work, since you are also discovering this type as individual asset. If you want to be able to do this, you need to add an init function. For example https://github.com/mondoohq/cnquery/blob/main/providers/gcp/resources/bigquery.go#L202-L250
There was a problem hiding this comment.
not going to work how?
It's included into auto-generated files, so what it's needed for atm is that zones are making separate resources
There was a problem hiding this comment.
i would remove the cloudflare_ prefix from all files. Seems like it's not needed, since we are already in the cloudflare provider
Includes: