a bit more coverage

mondemand · Jun 18, 2019 · d4db972 · d4db972
1 parent fbac56e
commit d4db972
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 0 deletions.
diff --git a/src/mondemand_perfmsg.erl b/src/mondemand_perfmsg.erl
@@ -316,6 +316,40 @@ perfmsg_test_ () ->
               lwes_event:from_binary(lwes_event:to_binary(to_lwes(P)),list)))
       end
     },
+    { "basic constructor test with contexts",
+      fun () ->
+        P = new (<<"foo">>, <<"bar">>, [{<<"baz">>,5,10}]),
+        ?assertEqual (<<"foo">>, id(P)),
+        ?assertEqual (<<"bar">>,caller_label(P)),
+        ?assertEqual (1, num_timings(P)),
+        [ T ] = timings(P),
+        ?assertEqual (<<"baz">>,timing_label (T)),
+        ?assertEqual (5, timing_start_time (T)),
+        ?assertEqual (10, timing_end_time (T)),
+        ?assertEqual ([],context (P)),
+        ?assertEqual ({0, P},
+          from_lwes(
+              lwes_event:from_binary(lwes_event:to_binary(to_lwes(P)),list))),
+        P2 = add_context(P, <<"ck0">>, <<"cv0">>),
+        ?assertEqual ([{<<"ck0">>,<<"cv0">>}], context(P2)),
+        ?assertEqual ({0, P2},
+          from_lwes(
+              lwes_event:from_binary(lwes_event:to_binary(to_lwes(P2)),list))),
+        P3 = add_contexts(P2, [{<<"ck2">>,<<"cv2">>},{<<"ck1">>,<<"cv1">>}]),
+        ?assertEqual ([{<<"ck2">>,<<"cv2">>},
+                       {<<"ck1">>,<<"cv1">>},
+                       {<<"ck0">>,<<"cv0">>}], context(P3)),
+        % sort order seems to change with serialize/deserialize test, so
+        % check with them sorted
+        {0, P4} =
+          from_lwes(
+                lwes_event:from_binary(lwes_event:to_binary(to_lwes(P3)),list)),
+        P5 = P3#md_perf_msg { context = lists:sort(P3#md_perf_msg.context) },
+        P6 = P4#md_perf_msg { context = lists:sort(P4#md_perf_msg.context) },
+        ?assertEqual (P5, P6)
+      end
+    },
+
     { "basic constructor multi-test",
       fun () ->
         P = new (<<"foo">>, <<"bar">>, [{<<"baz">>,5,10},{<<"bob">>,6,8}]),

diff --git a/src/mondemand_statsmsg.erl b/src/mondemand_statsmsg.erl
@@ -2065,6 +2065,11 @@ statsmsg_test_ () ->
         ?assertEqual (undefined, statset_from_string ("::")),
         ?assertEqual (gauge, string_to_type ("gauge")),
         ?assertEqual (gauge, string_to_type (<<"gauge">>)),
+        % unknown exists in some other implementations and is here for
+        % completeness
+        ?assertEqual (unknown, string_to_type ("unknown")),
+        ?assertEqual (unknown, string_to_type (<<"unknown">>)),
+        ?assertEqual (<<"unknown">>, type_to_string(unknown)),
         NewEvent = E1#lwes_event {
                      attrs = [{?LWES_INT_64, ?MD_RECEIPT_TIME, 5}
                               | E1#lwes_event.attrs ]},