-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some linter warnings #199
Conversation
Shellcheck is a little less noisy now.
|
Hmm. I think we're going to need to reevaluate some CI decisions. This last build took 7 hours (!) https://travis-ci.org/monasca/monasca-docker/builds/273282923?utm_source=github_status&utm_medium=notification I'm guessing some networking issue was involved, but it really isn't properly debuggable given how noisy the logs are. Short term this patch triggered too many container rebuilds, which takes more time and amplifies log output (monasca/dbuild#3). If we split this patch up to fix only a couple of modules at a time it should be able to pass CI. Long term we need to fix dbuild's logging issue and figure out why these builds are taking so long and possibly also put a hard limit on the number of modules we'll build in a single patchset. I've filed #200 to track this. FWIW this patch really isn't the cause of the problem but unfortunately I think we'll need to work around it while other things are cleaned up. |
Ups, sorry for this. I'll split it to smaller PRs. Hmmm, shouldn't person that open PR get mail from Travis that build failed? |
Yeah, you should have gotten a message... I guess we broke Travis in more ways than one 😃 |
Hmm, no mails with CI errors on my end from any PR... |
Some fixes for #191