add new cat breeds and fix dog breed classification #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabrinatoro
requested changes
May 13, 2024
There was a problem hiding this comment.
@katiermullen
It looks good except for the fact that we should have a source for the "has foundation stock" annotations.
Note that we do not have sources for "felis catus" SubClass of and for "canis lupus familiaris" (which is not ideal, but we could easily add the source for dog breed). However, I think we absolutely need to make sure that we have a source for the "has foundation stock" annotations to make sure we know where the information comes from.
Update with sources for has_foundation_stock
sabrinatoro
approved these changes
May 14, 2024
There was a problem hiding this comment.
It looks good! Approving and merging. Thank you @katiermullen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #160 - leaving open because @ImkeTammen may have additional comments about classification of German Pointer dogs.
closes #161