363 account for compound het variants #368
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaseminbridges
requested review from
julesjacobsen,
souzadevinicius and
matentzn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces enhanced ranking functionality to handle compound heterozygous variants in PhEval results through a new
grouping_idparameter. The grouping_id allows variants that contribute collectively to a phenotype (e.g., compound heterozygous variants within the same gene) to be ranked together (and not penalised), ensuring their combined effect is accurately represented in the analysis. If variants are not compound heterzygous, they will be ranked with the default method.If a
grouping_idis not specified the code will not break, it will just default to the current method of ranking variants - this is important as not all VGPAs will give an idea of whether a variant is compound het or not and so they can just dismiss this.