Abbreviation recasing: use all abbreviations #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update: Now adding synonyms for alt & included symbols, w/ type of mondo#abbreviation. - Misc updates: Todo comments. Renamed variables/methods for consistency and accuracy. Refactored some things.
- In previous commits, stated that this would also include 'included' symbols, but for now we have decided not to proceed with that. - Update: Now adding synonyms for alternative symbols, w/ type of mondo#abbreviation. - Update: Now stripping the text ', INCLUDED' from symbols. Previously was only doing for titles. - Update: For included & alternative titles/symbols ending in ', FORMERLY', these are being added as relatedSynonyms, and also being marked as owl:deprecated. - Misc updates: Updated some comments and codestyle.
- Bug fix: mondo#ABBREVIATION URI - Update: Typo and codestyle of cleanup_label()
- Update: Docstring to make clearer - Update: Typo fix - Update: Now "former" included titles/symbols are also being processed
- Update: Refactor: Cleaned some redundancy in how this was being called. Simplified code. Modularized other parts of code.
- Update: Now considering all abbreviations when checking a title and uppercasing them. Previously was only looking at the first preferred symbol. - Update: Refactored, added comments and todos, simplified code. - Bug fix: Was not actually uppercasing previously. The .replace() usage was incorrect.
joeflack4
force-pushed
the
abbrev-recasing-use-all
branch
from
7eefea5
to
788f267
Compare
- Add: A todo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #129
Changes
Abbreviation recasing: use all abbrevs
Results:
diff.diff.zip (also w/
.owls on google drive)