Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DEE31A and 31B #7934

Merged
merged 6 commits into from
Jul 12, 2024
Merged

Update DEE31A and 31B #7934

merged 6 commits into from
Jul 12, 2024

Conversation

yshwetar
Copy link
Collaborator

@yshwetar yshwetar commented Jul 8, 2024

Addresses #7641

  • Updated names and synonyms to represent new medical understanding of DEE31 as DEE31A
  • Updated definitions for 31A and 31B from OMIM. Included my ORCID and OMIM as annotations
  • Included broad and exact synonyms, along with ORCID and OMIM annotations for these

Addresses #7641

- Updated names and synonyms to represent new medical understanding of DEE31 as DEE31A
- Updated definitions for 31A and 31B from OMIM. Included my ORCID and OMIM as annotations
- Included broad and exact synonyms, along with ORCID and OMIM annotations for these
Copy link
Collaborator

@sabrinatoro sabrinatoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yshwetar some definition to update

src/ontology/mondo-edit.obo Show resolved Hide resolved
src/ontology/mondo-edit.obo Show resolved Hide resolved
@sabrinatoro sabrinatoro assigned yshwetar and unassigned sabrinatoro Jul 9, 2024
Replaced broad defintion for 31A. Changed definition for 31B to be of similar structure to 31A
@yshwetar yshwetar assigned sabrinatoro and unassigned yshwetar Jul 9, 2024
This was referenced Jul 9, 2024
Copy link
Collaborator

@sabrinatoro sabrinatoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yshwetar a VERY small change required.

src/ontology/mondo-edit.obo Show resolved Hide resolved
src/ontology/mondo-edit.obo Show resolved Hide resolved
@sabrinatoro sabrinatoro assigned yshwetar and unassigned sabrinatoro Jul 10, 2024
Changed definition to be for developmental and epileptic encephalopathies, and not early developmental and epileptic encephalopathies.

Also added a comma to 31B naming
Copy link
Member

@nicolevasilevsky nicolevasilevsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes needed - some edits needed to the synonyms. Thanks!

@nicolevasilevsky
Copy link
Member

@yshwetar please assign this back to me when you have made the edits, thanks!

Synonyms have letters capitalized - this was removed.
@nicolevasilevsky nicolevasilevsky removed their assignment Jul 12, 2024
Changed 'Disorder' to 'disorder' in synonym for 31B
@nicolevasilevsky
Copy link
Member

thanks for addressing all of the comments @yshwetar.

I added the term tracker item to these two terms. This can be merged after QC passes

@nicolevasilevsky nicolevasilevsky merged commit 23272d2 into master Jul 12, 2024
1 check passed
@nicolevasilevsky nicolevasilevsky deleted the issue-7641-3 branch July 12, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants