Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non exact xrefs from Mondo #6863

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove non exact xrefs from Mondo #6863

wants to merge 2 commits into from

Conversation

matentzn
Copy link
Member

@matentzn matentzn commented Nov 10, 2023

@cmungall
Copy link
Member

cmungall commented Dec 6, 2023

We used to have a more conservative approach, where we only threw out non-exact for ontologies that we had high quality comprehensive mappings for (e.g. OMIM); we know the end results here will have high recall and precision. For others like ICD10 we would not filter, so we were weighing recall above precision.

Your approach weighs precision more highly, so we'd end up with only ~1k ICD10 mappings, as opposed to ~10k. There is an argument for this but I think it's too big a change for the public release, so I would remove ICD10 SCTID UMLS from your regexp

src/ontology/Makefile Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants