DO NOT MERGE: Data build for #693 #694
Conversation
There was a problem hiding this comment.
Just observing larger than expected diff here in the signature files / unmapped .owl. I guess a new, large update from OMIM.
There was a problem hiding this comment.
@joeflack4 Haven't you made some changes to OMIM content representation recently? Can you think of some ways you could confirm if these gene additions and removals make sense by spot checking a few entries?
There was a problem hiding this comment.
From what I can see, my local mondo-genes.robot.tsv in omim repo should be a good reference to compare the HGNC IDs that appear there against what's in the mirror/component signatures in mondo-ingest. This file doesn't get committed so I can't check a diff, but face checking a few add/deletions, it looks consistent.
It is in a very separate part of the pipeline than the Gene-to-Disease stuff we've been working on.
The source data comes from mim2gene.txt, but it doesn't have HGNC IDs there. It has symbols, which get looked up on a known map to get the IDs. But I think the face checking is good enough. Still I'm in the spot of "looks like OMIM made a lot of updates recently" without knowing much else.
There was a problem hiding this comment.
Synonym sync files added as expected.
-_- Glad to see I'm the only one that is occasionally getting:
There was a problem hiding this comment.
Have you created/updated any aliases for any commands that is deleting this file?
There was a problem hiding this comment.
I haven't touched the makefile goals for this for some weeks I think.
Data build for #693