Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experimental] Update to eslint.config.js #890

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

glass-ships
Copy link
Collaborator

eslint has migrated from the .eslintrc.json to the new "flat config", eslint.config.js style.

This PR is somewhat experimental and

  • updates the new config style
  • addresses a number of linting/formatting errors that were (for some reason) caught with the new version but not previously

Some frontend tests are currently failing, which is definitely an argument for not bringing this in just yet. Further investigation required.

Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for monarch-app ready!

Name Link
🔨 Latest commit a404844
🔍 Latest deploy log https://app.netlify.com/sites/monarch-app/deploys/674dd3eb8717180008f66aa3
😎 Deploy Preview https://deploy-preview-890--monarch-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.14%. Comparing base (84dab5f) to head (a404844).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #890   +/-   ##
=======================================
  Coverage   71.14%   71.14%           
=======================================
  Files          91       91           
  Lines        3136     3136           
=======================================
  Hits         2231     2231           
  Misses        905      905           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant