Error messages #96
Error messages #96
Conversation
lnrekerle
force-pushed
the
Error-messages
branch
from
4574a1f to
cf50c5e
Compare
|
I think this is good for now, we will obviously want to add more errors as we continue. |
There was a problem hiding this comment.
Hi @lnrekerle thanks a lot for the updates.
On the lower level, I think the changes look good except for that one thing in the builder that I mention below. Please consider changing that, because I think this is a bug that can deceive the users and cause confusion.
On the higher level, I would like to see how the logging looks like in an example analysis. Therefore, let's please wait with merging until you're finished with #46. Then we can see if the logging looks reasonable.
Thank you!
There was a problem hiding this comment.
Hi @lnrekerle ,
I have some "cosmetic" suggestions. Please address them, if you wish so, and then feel free to merge.
Thanks!
#83 #52
This PR will update error messages and create logging files for Warnings/Info that will be easier for users to understand.
edit:
Also will close #108